Skip to content

Commit 4d1a3c6

Browse files
committed
Fixed assigning default server url for armadillo
1 parent 0a380f7 commit 4d1a3c6

2 files changed

Lines changed: 11 additions & 5 deletions

File tree

tests/testthat/connection_to_datasets/init_local_settings.R

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@ init.server.url <- function()
1515
}
1616
else
1717
{
18-
# server.url <- "http://127.0.0.1:8080/"
19-
# server.url <- "http://localhost:8080/"
20-
server.url <- "https://localhost:8443/"
18+
server.url <- NULL
2119
}
2220
return (server.url)
2321
}

tests/testthat/connection_to_datasets/login_details.R

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,11 @@ if (! is.null(getOption("default_driver"))) {
2222
}
2323

2424
if ((ds.test_env$driver == "DSLiteDriver") || (ds.test_env$driver == "OpalDriver")) {
25-
opal.url <- ds.test_env$server_url
25+
if (! is.null(ds.test_env$server_url)) {
26+
opal.url <- ds.test_env$server_url
27+
} else {
28+
opal.url <- "https://localhost:8443/"
29+
}
2630

2731
ds.test_env$ping_url <- opal.url
2832
ds.test_env$ping_config <- config(timeout=5)
@@ -45,7 +49,11 @@ if ((ds.test_env$driver == "DSLiteDriver") || (ds.test_env$driver == "OpalDriver
4549

4650
ds.test_env$secure_login_details <- TRUE
4751
} else if (ds.test_env$driver == "ArmadilloDriver") {
48-
armadillo.url <- ds.test_env$server_url
52+
if (! is.null(ds.test_env$server_url)) {
53+
armadillo.url <- ds.test_env$server_url
54+
} else {
55+
armadillo.url <- "http://localhost:8080/"
56+
}
4957

5058
ds.test_env$ping_url <- armadillo.url
5159
ds.test_env$ping_config <- config(timeout=5)

0 commit comments

Comments
 (0)