Skip to content

Commit 50e1caf

Browse files
committed
docs: added reference to performance in pr template
1 parent 58b24b8 commit 50e1caf

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@
1313
### Testing instructions
1414
- [ ] Writen client-side unit tests for unhappy flow
1515
- [ ] Run `devtools::test(filter = "smk-|disc|arg")` and check it passes
16-
- [ ] Run `devtools::check(args = '--no-tests')` and check it passes (we run tests separately to skip performance checks)
16+
- [ ] Run `devtools::check(args = '--no-tests')` and check it passes
1717
- [ ] Run `devtools::build()` and check it builds without errors
18+
- [ ] Check that the continuous integration checks pass on the pull request branch. Note that the performance test relating to your function may fail, as failure is also triggered by a dramatic improval in performance!
1819

1920
## Instructions & checklist for PR reviewers
2021
- [ ] Checkout this branch as well as the corresponding branch of dsBase
@@ -23,3 +24,4 @@
2324
- [ ] Run `devtools::test(filter = "smk-|disc|arg")` and check it passes
2425
- [ ] Run `devtools::check(args = '--no-tests')` and check it passes (we run tests separately to skip performance checks)
2526
- [ ] Run `devtools::build()` and check it builds without errors
27+
- [ ] Check that the continuous integration checks pass on the pull request branch (see above note on performance checks)

0 commit comments

Comments
 (0)