Skip to content

Commit 76a1014

Browse files
Merge pull request #72 from datashield/v6.3.6-dev-feat/standardise-df
V6.3.6 dev feat/standardise df
2 parents 5a637a9 + 0af6b22 commit 76a1014

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

dsBase_6.3.6-permissive.tar.gz

3.18 MB
Binary file not shown.

tests/testthat/connection_to_datasets/init_studies_datasets.R

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,8 @@ init.studies.dataset.stand <- function(variables)
229229
{
230230
builder <- DSI::newDSLoginBuilder(.silent = TRUE)
231231
builder$append(server = "sim1", url = ds.test_env$server_url_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "STANDARDISE.std_1", options=ds.test_env$options_1)
232-
builder$append(server = "sim2", url = ds.test_env$server_url_2, user = ds.test_env$user_2, password = ds.test_env$password_2, table = "STANDARDISE.std_1", options=ds.test_env$options_2)
233-
builder$append(server = "sim3", url = ds.test_env$server_url_3, user = ds.test_env$user_3, password = ds.test_env$password_3, table = "STANDARDISE.std_1", options=ds.test_env$options_3)
232+
builder$append(server = "sim2", url = ds.test_env$server_url_2, user = ds.test_env$user_2, password = ds.test_env$password_2, table = "STANDARDISE.std_2", options=ds.test_env$options_2)
233+
builder$append(server = "sim3", url = ds.test_env$server_url_3, user = ds.test_env$user_3, password = ds.test_env$password_3, table = "STANDARDISE.std_3", options=ds.test_env$options_3)
234234
ds.test_env$login.data <- builder$build()
235235
}
236236
else if (ds.test_env$driver == "ArmadilloDriver")
@@ -286,8 +286,8 @@ init.studies.dataset.stand <- function(variables)
286286
{
287287
builder <- DSI::newDSLoginBuilder(.silent = TRUE)
288288
builder$append(server = "sim1", url = ds.test_env$server_url_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "STANDARDISE.std_1", options=ds.test_env$options_1)
289-
builder$append(server = "sim2", url = ds.test_env$server_url_2, user = ds.test_env$user_2, password = ds.test_env$password_2, table = "STANDARDISE.std_1", options=ds.test_env$options_2)
290-
builder$append(server = "sim3", url = ds.test_env$server_url_3, user = ds.test_env$user_3, password = ds.test_env$password_3, table = "STANDARDISE.std_1", options=ds.test_env$options_3)
289+
builder$append(server = "sim2", url = ds.test_env$server_url_2, user = ds.test_env$user_2, password = ds.test_env$password_2, table = "STANDARDISE.std_2", options=ds.test_env$options_2)
290+
builder$append(server = "sim3", url = ds.test_env$server_url_3, user = ds.test_env$user_3, password = ds.test_env$password_3, table = "STANDARDISE.std_3", options=ds.test_env$options_3)
291291
ds.test_env$login.data <- builder$build()
292292
}
293293
else if (ds.test_env$driver == "ArmadilloDriver")

tests/testthat/connection_to_datasets/login_details.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ if ((ds.test_env$driver == "DSLiteDriver") || (ds.test_env$driver == "OpalDriver
6060
ds.test_env$ping_url <- armadillo.url
6161
ds.test_env$ping_user <- getOption("armadillo.user", "admin")
6262
ds.test_env$ping_password <- getOption("armadillo.password", "admin")
63-
ds.test_env$ping_options <- "list(timeout=60)"
63+
ds.test_env$ping_options <- config(timeout=60)
6464

6565
ds.test_env$server_url_1 <- armadillo.url
6666
ds.test_env$server_url_2 <- armadillo.url

tests/testthat/test-smk-ds.standardiseDf.R

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ test_that("setup", {
1717
#
1818
# Tests
1919
#
20-
2120
####################################################################################################
2221
# Code that will be used in multiple tests
2322
####################################################################################################

0 commit comments

Comments
 (0)