Skip to content

Commit 8282242

Browse files
committed
fix: re-seed only when specified
current approach without else statement will always re-seed when no seed value provided, making it impossible to get reproducible results
1 parent a38fe4c commit 8282242

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

R/ds.rBinom.R

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,10 +211,11 @@ single.integer.seed<-c(single.integer.seed,seed.as.integer.study.specific)
211211
if(seed.as.text=="NULL"){
212212
cat("NO SEED SET IN STUDY",study.id,"\n\n")
213213

214-
}
214+
} else {
215215
calltext <- paste0("setSeedDS(", seed.as.text, ")")
216216
ssDS.obj[[study.id]] <- DSI::datashield.aggregate(datasources[study.id], as.symbol(calltext))
217217
}
218+
}
218219
cat("\n\n")
219220

220221

R/ds.rUnif.R

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,9 +230,10 @@ single.integer.seed<-c(single.integer.seed,seed.as.integer.study.specific)
230230
if(seed.as.text=="NULL"){
231231
cat("NO SEED SET IN STUDY",study.id,"\n")
232232

233-
}
233+
} else {
234234
calltext <- paste0("setSeedDS(", seed.as.text, ")")
235235
ssDS.obj[[study.id]] <- DSI::datashield.aggregate(datasources[study.id], as.symbol(calltext))
236+
}
236237
}
237238

238239

0 commit comments

Comments
 (0)