Skip to content

Commit bbb5364

Browse files
Merge pull request datashield#680 from StuartWheater/v6.3.6-dev
Update/fix to 'Opal' http/https config
2 parents bfe21f0 + 4d1a3c6 commit bbb5364

2 files changed

Lines changed: 14 additions & 7 deletions

File tree

tests/testthat/connection_to_datasets/init_local_settings.R

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ init.server.url <- function()
1515
}
1616
else
1717
{
18-
# server.url <- "http://127.0.0.1:8080/"
19-
server.url <- "http://localhost:8080/"
18+
server.url <- NULL
2019
}
2120
return (server.url)
2221
}

tests/testthat/connection_to_datasets/login_details.R

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,11 @@ if (! is.null(getOption("default_driver"))) {
2222
}
2323

2424
if ((ds.test_env$driver == "DSLiteDriver") || (ds.test_env$driver == "OpalDriver")) {
25-
opal.url <- ds.test_env$server_url
25+
if (! is.null(ds.test_env$server_url)) {
26+
opal.url <- ds.test_env$server_url
27+
} else {
28+
opal.url <- "https://localhost:8443/"
29+
}
2630

2731
ds.test_env$ping_url <- opal.url
2832
ds.test_env$ping_config <- config(timeout=5)
@@ -39,13 +43,17 @@ if ((ds.test_env$driver == "DSLiteDriver") || (ds.test_env$driver == "OpalDriver
3943
ds.test_env$password_2 <- getOption("opal.password", "datashield_test&")
4044
ds.test_env$password_3 <- getOption("opal.password", "datashield_test&")
4145

42-
ds.test_env$options_1 <- "list()"
43-
ds.test_env$options_2 <- "list()"
44-
ds.test_env$options_3 <- "list()"
46+
ds.test_env$options_1 <- "list(ssl_verifyhost=0, ssl_verifypeer=0)"
47+
ds.test_env$options_2 <- "list(ssl_verifyhost=0, ssl_verifypeer=0)"
48+
ds.test_env$options_3 <- "list(ssl_verifyhost=0, ssl_verifypeer=0)"
4549

4650
ds.test_env$secure_login_details <- TRUE
4751
} else if (ds.test_env$driver == "ArmadilloDriver") {
48-
armadillo.url <- ds.test_env$server_url
52+
if (! is.null(ds.test_env$server_url)) {
53+
armadillo.url <- ds.test_env$server_url
54+
} else {
55+
armadillo.url <- "http://localhost:8080/"
56+
}
4957

5058
ds.test_env$ping_url <- armadillo.url
5159
ds.test_env$ping_config <- config(timeout=5)

0 commit comments

Comments
 (0)