Merge pull request datashield#572 from ESCRI11/fix-seed

StuartWheater · web-flow · commit d3c08cd43b04 · 2025-03-11T11:57:02.000Z
fix: re-seed only when specified
diff --git a/R/ds.rBinom.R b/R/ds.rBinom.R
@@ -216,10 +216,11 @@ single.integer.seed<-c(single.integer.seed,seed.as.integer.study.specific)
 if(seed.as.text=="NULL"){
 cat("NO SEED SET IN STUDY",study.id,"\n\n")
 
-}
+} else {
   calltext <- paste0("setSeedDS(", seed.as.text, ")")
   ssDS.obj[[study.id]] <- DSI::datashield.aggregate(datasources[study.id], as.symbol(calltext))
 }
+}
 cat("\n\n")
 
 
diff --git a/R/ds.rUnif.R b/R/ds.rUnif.R
@@ -234,9 +234,10 @@ single.integer.seed<-c(single.integer.seed,seed.as.integer.study.specific)
 if(seed.as.text=="NULL"){
 cat("NO SEED SET IN STUDY",study.id,"\n")
 
-}
+} else {
   calltext <- paste0("setSeedDS(", seed.as.text, ")")
   ssDS.obj[[study.id]] <- DSI::datashield.aggregate(datasources[study.id], as.symbol(calltext))
+}
 } 
 
 

Original file line number	Diff line number	Diff line change
`@@ -234,9 +234,10 @@ single.integer.seed<-c(single.integer.seed,seed.as.integer.study.specific)`
`234`	`234`	`if(seed.as.text=="NULL"){`
`235`	`235`	`cat("NO SEED SET IN STUDY",study.id,"\n")`
`236`	`236`
`237`		`-}`
	`237`	`+} else {`
`238`	`238`	`calltext <- paste0("setSeedDS(", seed.as.text, ")")`
`239`	`239`	`ssDS.obj[[study.id]] <- DSI::datashield.aggregate(datasources[study.id], as.symbol(calltext))`
	`240`	`+}`
`240`	`241`	`}`
`241`	`242`
`242`	`243`