Skip to content

Commit fcad7c6

Browse files
committed
code improvements and increase test coverage
1 parent fc9dc2c commit fcad7c6

7 files changed

Lines changed: 78 additions & 4 deletions

File tree

NAMESPACE

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
export(ds.Boole)
44
export(ds.abs)
55
export(ds.asCharacter)
6+
export(ds.asDataFrame)
67
export(ds.asDataMatrix)
78
export(ds.asFactor)
89
export(ds.asFactorSimple)

R/ds.Boole.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,13 +172,13 @@ ds.Boole<-function(V1=NULL, V2=NULL, Boolean.operator=NULL, numeric.output=TRUE,
172172
stop(paste0("An unrecognized Boolean operator, ", Boolean.operator, ", has provide"), call.=FALSE)
173173
}
174174

175-
# if no value spcified for output object, then specify a default
175+
# if no value specified for output object, then specify a default
176176
if(is.null(newobj)){
177177
newobj <- paste0(V1,"_Boole")
178178
}
179179

180180
# CALL THE MAIN SERVER SIDE FUNCTION
181-
calltext <- call("BooleDS", V1, V2, BO.n, na.assign,numeric.output)
181+
calltext <- call("BooleDS", V1, V2, BO.n, na.assign, numeric.output)
182182
DSI::datashield.assign(datasources, newobj, calltext)
183183

184184
#############################################################################################################

R/ds.boxPlot.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ ds.boxPlot <- function(x, variables = NULL, group = NULL, group2 = NULL, xlabel
135135
}
136136
}
137137

138-
# Once all checks are passed, call the appropiate server functions
138+
# Once all checks are passed, call the appropriate server functions
139139
if("data.frame" %in% cls){
140140
ds.boxPlotGG_table(x, variables, group, group2, xlabel, ylabel, type, datasources)
141141
}

docs/~$itemap.xml

-162 Bytes
Binary file not shown.

man/ds.asDataFrame.Rd

Lines changed: 72 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
load("/Users/demetrisavraam/Desktop/GitHub/dsBaseClient/tests/testthat/data_files/SURVIVAL/EXPAND_MISSING/EXPAND_WITH_MISSING1.rda")

tests/testthat/test-arg-ds.make.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ connect.studies.dataset.cnsim(list("LAB_TSC"))
1919
#
2020

2121
context("ds.make::arg::test errors")
22-
test_that("make_erros", {
22+
test_that("make_errors", {
2323
expect_error(ds.make(), "Please give the name of object to assign or an expression to evaluate and assign.!\n", fixed=TRUE)
2424
})
2525

0 commit comments

Comments
 (0)