Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
e2d0fe8
'8443' to '8080' for Opal
StuartWheater Mar 23, 2026
f855e52
Switch to Opal via http and 8080
StuartWheater Apr 3, 2026
7cddd3a
Merge pull request #659 from StuartWheater/v6.3.6-dev
StuartWheater Apr 9, 2026
ff55303
Permit perf test duration to be set, seconds, by environment variable…
StuartWheater Apr 10, 2026
5a3bf58
Permit perf test duration to be set, seconds, by environment variable…
StuartWheater Apr 13, 2026
2cbe807
Merge pull request #660 from StuartWheater/v6.3.6-dev_feat-perf-support
StuartWheater Apr 14, 2026
2afaa7a
feat: support remote Armadillo URLs via local_settings.csv
timcadman Apr 19, 2026
5b13e34
try: specify full url in local settings
timcadman Apr 23, 2026
9430087
Fixed libuv1-dev issue
StuartWheater Apr 23, 2026
20c7c65
Merge pull request #667 from datashield/v6.3.6-dev_fix/libuv1
StuartWheater Apr 24, 2026
ed7f5a5
Merge branch 'datashield:feat/armadillo-remote-url' into feat/armadil…
StuartWheater Apr 24, 2026
aa82882
Reworked to contain 'server url'
StuartWheater Apr 24, 2026
36aa13a
Fixed typo
StuartWheater Apr 24, 2026
9258032
fix(glm): get family name from object (legacy dsBase) or from returne…
ymarcon Apr 22, 2026
e92a78d
Merge pull request #666 from datashield/fix/glm-family
ymarcon May 1, 2026
b219c03
Reworking Armadillo logging config
StuartWheater May 8, 2026
cd6346f
Updated 'hp-laptop' perf profile
StuartWheater May 8, 2026
dc9b3e0
Update dsBase tars and associated 'azure-pipelines'
StuartWheater May 8, 2026
61c7975
Update dsBase tars and associated files
StuartWheater May 8, 2026
a492c22
Merge branch 'v6.3.6-dev' of github.com:StuartWheater/dsBaseClient in…
StuartWheater May 8, 2026
cbef6da
Switch to Roxygen 8.0.0
StuartWheater May 12, 2026
4637d79
Fixed test which check class of family variable
StuartWheater May 12, 2026
d153176
Merge pull request #670 from datashield/v6.3.6-dev-fix/family-class
StuartWheater May 13, 2026
10fe92d
Merge branch 'datashield:v6.3.6-dev' into v6.3.6-dev
StuartWheater May 13, 2026
2cccc17
Merge pull request #669 from StuartWheater/v6.3.6-dev
StuartWheater May 13, 2026
1915a1f
Merge branch 'v6.3.6-dev' of github.com:StuartWheater/dsBaseClient in…
StuartWheater May 13, 2026
a088bd5
Merge pull request #668 from StuartWheater/feat/armadillo-remote-url
StuartWheater May 14, 2026
1dff161
Integration of STANDARDISE datasets
StuartWheater May 28, 2026
50a441b
Merge pull request #676 from StuartWheater/v6.3.6-dev
StuartWheater May 29, 2026
4516a08
Merge branch 'v6.4.0-dev' into 6.4.0-6.3.6_update
StuartWheater Jun 4, 2026
1303e34
Fixes for update to 6.4.0
StuartWheater Jun 4, 2026
41eb307
Fixed some tests
StuartWheater Jun 5, 2026
10d90fd
Merge branch 'v6.4.0-dev' into 6.4.0-6.3.6_update
StuartWheater Jun 8, 2026
99d23a5
Merge pull request #664 from datashield/feat/armadillo-remote-url
timcadman Jun 8, 2026
3edd081
Merge pull request #69 from datashield/v6.3.6-dev
StuartWheater Jun 10, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dsBaseClient_test_suite.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ jobs:
- name: Install dsBase to Armadillo
run: |
curl -u admin:admin -X GET http://localhost:8080/packages
curl -u admin:admin -H 'Content-Type: multipart/form-data' -F "file=@dsBase_6.3.5-permissive.tar.gz" -X POST http://localhost:8080/install-package
curl -u admin:admin -H 'Content-Type: multipart/form-data' -F "file=@dsBase_6.3.6-permissive.tar.gz" -X POST http://localhost:8080/install-package
sleep 60
docker restart dsbaseclient-armadillo-1
sleep 30
Expand Down
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,6 @@ Suggests:
DSOpal,
DSMolgenisArmadillo,
DSLite
RoxygenNote: 7.3.3
Encoding: UTF-8
Language: en-GB
Config/roxygen2/version: 8.0.0
5 changes: 3 additions & 2 deletions R/ds.glm.R
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,8 @@ ds.glm <- function(formula=NULL, data=NULL, family=NULL, offset=NULL, weights=NU
# Sum participants only during first iteration.
nsubs.total<-Reduce(f="+", .select(study.summary, 'numsubs'))
# Save family
f <- study.summary[[1]]$family
family.value <- study.summary[[1]]$family
f <- if (is.list(family.value) && "family" %in% names(family.value)) family.value$family else family.value
}

#Create variance covariance matrix as inverse of information matrix
Expand Down Expand Up @@ -640,7 +641,7 @@ ds.glm <- function(formula=NULL, data=NULL, family=NULL, offset=NULL, weights=NU
beta.vect.final<-beta.vect.next

scale.par <- 1
if(f$family== 'gaussian') {
if(f == 'gaussian') {
scale.par <- dev.total / (nsubs.total-length(beta.vect.next))
}

Expand Down
10 changes: 5 additions & 5 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -215,13 +215,13 @@ jobs:
# Install dsBase.
# If previous steps have failed then don't run.
- bash: |
R -q -e "library(opalr); opal <- opal.login(username = 'administrator', password = 'datashield_test&', url = 'https://localhost:8443', opts = list(ssl_verifyhost=0, ssl_verifypeer=0)); opal.put(opal, 'system', 'conf', 'general', '_rPackage'); opal.logout(opal)"
R -q -e "library(opalr); opal <- opal.login(username = 'administrator', password = 'datashield_test&', url = 'http://localhost:8080'); opal.put(opal, 'system', 'conf', 'general', '_rPackage'); opal.logout(opal)"

R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='https://localhost:8443/', opts = list(ssl_verifyhost=0, ssl_verifypeer=0)); dsadmin.install_github_package(opal, 'dsBase', username = 'datashield', ref = 'v6.3.5-dev'); opal.logout(opal)"
R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='http://localhost:8080/'); dsadmin.install_github_package(opal, 'dsBase', username = 'datashield', ref = 'v6.4.0-dev'); opal.logout(opal)"

sleep 60

R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='https://localhost:8443/', opts = list(ssl_verifyhost=0, ssl_verifypeer=0)); dsadmin.set_option(opal, 'default.datashield.privacyControlLevel', 'permissive'); opal.logout(opal)"
R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='http://localhost:8080/'); dsadmin.set_option(opal, 'default.datashield.privacyControlLevel', 'permissive'); opal.logout(opal)"

workingDirectory: $(Pipeline.Workspace)/dsBaseClient/tests/testthat/data_files
displayName: 'Install dsBase to Opal, as set disclosure test options'
Expand Down Expand Up @@ -344,9 +344,9 @@ jobs:
# If previous steps have failed then don't run
- bash: |

R -q -e "library(opalr); opal <- opal.login(username = 'administrator', password = 'datashield_test&', url = 'https://localhost:8443', opts = list(ssl_verifyhost=0, ssl_verifypeer=0)); opal.put(opal, 'system', 'conf', 'general', '_rPackage'); opal.logout(opal)"
R -q -e "library(opalr); opal <- opal.login(username = 'administrator', password = 'datashield_test&', url = 'http://localhost:8080/'); opal.put(opal, 'system', 'conf', 'general', '_rPackage'); opal.logout(opal)"

R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='https://localhost:8443/', opts = list(ssl_verifyhost=0, ssl_verifypeer=0)); dsadmin.install_github_package(opal, 'dsDanger', username = 'datashield', ref = '6.3.4'); opal.logout(opal)"
R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='http://localhost:8080/'); dsadmin.install_github_package(opal, 'dsDanger', username = 'datashield', ref = '6.3.4'); opal.logout(opal)"

workingDirectory: $(Pipeline.Workspace)/dsBaseClient
displayName: 'Install dsDanger package on Opal server'
Expand Down
3 changes: 2 additions & 1 deletion docker-compose_opal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ services:
image: datashield/opal_citest:latest
ports:
- 8443:8443
- 8080:8080
links:
- mongo
- rock
Expand All @@ -15,7 +16,7 @@ services:
- ROCK_HOSTS=rock:8085
- ROCK_ADMINISTRATOR_PASSWORD=foobar
mongo:
image: mongo:6.0.27
image: mongo:8.0
environment:
- MONGO_INITDB_ROOT_USERNAME=root
- MONGO_INITDB_ROOT_PASSWORD=foobar
Expand Down
10 changes: 5 additions & 5 deletions opal_azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -215,13 +215,13 @@ jobs:
# Install dsBase.
# If previous steps have failed then don't run.
- bash: |
R -q -e "library(opalr); opal <- opal.login(username = 'administrator', password = 'datashield_test&', url = 'https://localhost:8443', opts = list(ssl_verifyhost=0, ssl_verifypeer=0)); opal.put(opal, 'system', 'conf', 'general', '_rPackage'); opal.logout(opal)"
R -q -e "library(opalr); opal <- opal.login(username = 'administrator', password = 'datashield_test&', url = 'http://localhost:8080'); opal.put(opal, 'system', 'conf', 'general', '_rPackage'); opal.logout(opal)"

R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='https://localhost:8443/', opts = list(ssl_verifyhost=0, ssl_verifypeer=0)); dsadmin.install_github_package(opal, 'dsBase', username = 'datashield', ref = 'v6.3.5-dev'); opal.logout(opal)"
R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='http://localhost:8080/'); dsadmin.install_github_package(opal, 'dsBase', username = 'datashield', ref = 'v6.4.0-dev'); opal.logout(opal)"

sleep 60

R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='https://localhost:8443/', opts = list(ssl_verifyhost=0, ssl_verifypeer=0)); dsadmin.set_option(opal, 'default.datashield.privacyControlLevel', 'permissive'); opal.logout(opal)"
R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='http://localhost:8080/'); dsadmin.set_option(opal, 'default.datashield.privacyControlLevel', 'permissive'); opal.logout(opal)"

workingDirectory: $(Pipeline.Workspace)/dsBaseClient/tests/testthat/data_files
displayName: 'Install dsBase to Opal, as set disclosure test options'
Expand Down Expand Up @@ -344,9 +344,9 @@ jobs:
# If previous steps have failed then don't run
- bash: |

R -q -e "library(opalr); opal <- opal.login(username = 'administrator', password = 'datashield_test&', url = 'https://localhost:8443', opts = list(ssl_verifyhost=0, ssl_verifypeer=0)); opal.put(opal, 'system', 'conf', 'general', '_rPackage'); opal.logout(opal)"
R -q -e "library(opalr); opal <- opal.login(username = 'administrator', password = 'datashield_test&', url = 'http://localhost:8080/'); opal.put(opal, 'system', 'conf', 'general', '_rPackage'); opal.logout(opal)"

R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='https://localhost:8443/', opts = list(ssl_verifyhost=0, ssl_verifypeer=0)); dsadmin.install_github_package(opal, 'dsDanger', username = 'datashield', ref = '6.3.4'); opal.logout(opal)"
R -q -e "library(opalr); opal <- opal.login('administrator','datashield_test&', url='http://localhost:8080/'); dsadmin.install_github_package(opal, 'dsDanger', username = 'datashield', ref = '6.3.4'); opal.logout(opal)"

workingDirectory: $(Pipeline.Workspace)/dsBaseClient
displayName: 'Install dsDanger package on Opal server'
Expand Down
11 changes: 8 additions & 3 deletions tests/docker/armadillo/standard/config/application.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,13 @@ stdout.log.path: '/logs/armadillo.log'

logging:
level:
root: INFO
root: "warn"
## change to DEBUG to have more details, typically when developing
org.molgenis: INFO
org.molgenis: "warn"
## Don't log upload data
org.apache.coyote.http11.Http11InputBuffer: INFO
org.apache.coyote.http11.Http11InputBuffer: "warn"
## SpringFramework
org.springframework.boot: "warn"
org.springframework.web: "warn"
org.springframework.core: "warn"
org.springframework.codex: "warn"
12 changes: 6 additions & 6 deletions tests/testthat/connection_to_datasets/init_discordant_datasets.R
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@ init.discordant.dataset.simple <- function(variables)
if (ds.test_env$driver == "OpalDriver")
{
builder <- DSI::newDSLoginBuilder(.silent = TRUE)
builder$append(server = "discordant1", url = ds.test_env$ip_address_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "DISCORDANT.DISCORDANT_STUDY1", options=ds.test_env$options_1)
builder$append(server = "discordant2", url = ds.test_env$ip_address_2, user = ds.test_env$user_2, password = ds.test_env$password_2, table = "DISCORDANT.DISCORDANT_STUDY2", options=ds.test_env$options_2)
builder$append(server = "discordant3", url = ds.test_env$ip_address_3, user = ds.test_env$user_3, password = ds.test_env$password_3, table = "DISCORDANT.DISCORDANT_STUDY3", options=ds.test_env$options_3)
builder$append(server = "discordant1", url = ds.test_env$server_url_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "DISCORDANT.DISCORDANT_STUDY1", options=ds.test_env$options_1)
builder$append(server = "discordant2", url = ds.test_env$server_url_2, user = ds.test_env$user_2, password = ds.test_env$password_2, table = "DISCORDANT.DISCORDANT_STUDY2", options=ds.test_env$options_2)
builder$append(server = "discordant3", url = ds.test_env$server_url_3, user = ds.test_env$user_3, password = ds.test_env$password_3, table = "DISCORDANT.DISCORDANT_STUDY3", options=ds.test_env$options_3)
ds.test_env$login.data <- builder$build()
}
else if (ds.test_env$driver == "ArmadilloDriver")
{
builder <- DSI::newDSLoginBuilder(.silent = TRUE)
builder$append(server = "discordant1", url = ds.test_env$ip_address_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "datashield/discordant/DISCORDANT_STUDY1", driver = "ArmadilloDriver")
builder$append(server = "discordant2", url = ds.test_env$ip_address_2, user = ds.test_env$user_2, password = ds.test_env$password_2, table = "datashield/discordant/DISCORDANT_STUDY2", driver = "ArmadilloDriver")
builder$append(server = "discordant3", url = ds.test_env$ip_address_3, user = ds.test_env$user_3, password = ds.test_env$password_3, table = "datashield/discordant/DISCORDANT_STUDY3", driver = "ArmadilloDriver")
builder$append(server = "discordant1", url = ds.test_env$server_url_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "datashield/discordant/DISCORDANT_STUDY1", driver = "ArmadilloDriver")
builder$append(server = "discordant2", url = ds.test_env$server_url_2, user = ds.test_env$user_2, password = ds.test_env$password_2, table = "datashield/discordant/DISCORDANT_STUDY2", driver = "ArmadilloDriver")
builder$append(server = "discordant3", url = ds.test_env$server_url_3, user = ds.test_env$user_3, password = ds.test_env$password_3, table = "datashield/discordant/DISCORDANT_STUDY3", driver = "ArmadilloDriver")
ds.test_env$login.data <- builder$build()
}
else
Expand Down
27 changes: 16 additions & 11 deletions tests/testthat/connection_to_datasets/init_local_settings.R
Original file line number Diff line number Diff line change
@@ -1,28 +1,33 @@
#this file stores some settings for the continuous integration and local testing.
#
# The file "connection_to_datasets/local_settings.csv" (within the directory "tests/testthat") contains, if present,
# values which can be used to affect the behavious of the continuous integration.
#
# The server URL is in a CVS file, being the value of the first column, first row.
#

init.ip.address <- function()
init.server.url <- function()
{
file.name <- init.local.settings()
if (file.exists(file.name))
{
content <- read.csv(file.name, header = FALSE)
ip.address <- as.character(content[[1]][1])
content <- read.csv(file.name, header = FALSE)
server.url <- as.character(content[[1]][1])
}
else
{
# ip.address <- "127.0.0.1"
ip.address <- "localhost"
# server.url <- "http://127.0.0.1:8080/"
server.url <- "http://localhost:8080/"
}
return (ip.address)
return (server.url)
}



init.local.settings <- function()
{
path <- getwd()
path <- getwd()
sub.folder.name <- "/connection_to_datasets/"
file.name <- "local_settings.csv"
return(paste(path, sub.folder.name,file.name, sep=""))

file.name <- "local_settings.csv"

return(paste(path, sub.folder.name, file.name, sep=""))
}
12 changes: 6 additions & 6 deletions tests/testthat/connection_to_datasets/init_mediation_datasets.R
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ init.mediation.dataset.upb <- function(variables)
if (ds.test_env$driver == "OpalDriver")
{
builder <- DSI::newDSLoginBuilder(.silent = TRUE)
builder$append(server = "study1", url = ds.test_env$ip_address_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "MEDIATION.UPBdata1", options=ds.test_env$options_1)
builder$append(server = "study2", url = ds.test_env$ip_address_2, user = ds.test_env$user_2, password = ds.test_env$password_2, table = "MEDIATION.UPBdata2", options=ds.test_env$options_2)
builder$append(server = "study3", url = ds.test_env$ip_address_3, user = ds.test_env$user_3, password = ds.test_env$password_3, table = "MEDIATION.UPBdata3", options=ds.test_env$options_3)
builder$append(server = "study1", url = ds.test_env$server_url_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "MEDIATION.UPBdata1", options=ds.test_env$options_1)
builder$append(server = "study2", url = ds.test_env$server_url_2, user = ds.test_env$user_2, password = ds.test_env$password_2, table = "MEDIATION.UPBdata2", options=ds.test_env$options_2)
builder$append(server = "study3", url = ds.test_env$server_url_3, user = ds.test_env$user_3, password = ds.test_env$password_3, table = "MEDIATION.UPBdata3", options=ds.test_env$options_3)
ds.test_env$login.data <- builder$build()
}
else
Expand All @@ -25,7 +25,7 @@ init.mediation.dataset.student <- function(variables)
if (ds.test_env$driver == "OpalDriver")
{
builder <- DSI::newDSLoginBuilder(.silent = TRUE)
builder$append(server = "study1", url = ds.test_env$ip_address_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "MEDIATION.student", options=ds.test_env$options_1)
builder$append(server = "study1", url = ds.test_env$server_url_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "MEDIATION.student", options=ds.test_env$options_1)
ds.test_env$login.data <- builder$build()
}
else
Expand All @@ -43,7 +43,7 @@ init.mediation.dataset.framing <- function(variables)
if (ds.test_env$driver == "OpalDriver")
{
builder <- DSI::newDSLoginBuilder(.silent = TRUE)
builder$append(server = "study1", url = ds.test_env$ip_address_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "MEDIATION.framing", options=ds.test_env$options_1)
builder$append(server = "study1", url = ds.test_env$server_url_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "MEDIATION.framing", options=ds.test_env$options_1)
ds.test_env$login.data <- builder$build()
}
else
Expand All @@ -61,7 +61,7 @@ init.mediation.dataset.vv2015 <- function(variables)
if (ds.test_env$driver == "OpalDriver")
{
builder <- DSI::newDSLoginBuilder(.silent = TRUE)
builder$append(server = "study1", url = ds.test_env$ip_address_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "MEDIATION.vv2015", options=ds.test_env$options_1)
builder$append(server = "study1", url = ds.test_env$server_url_1, user = ds.test_env$user_1, password = ds.test_env$password_1, table = "MEDIATION.vv2015", options=ds.test_env$options_1)
ds.test_env$login.data <- builder$build()
}
else
Expand Down
Loading
Loading