Ethan/thermocouple#6
Conversation
added in proper SPI for thermocouple in main_avionics as SystemDefines created and started writing thermocouple task
EtSubas
left a comment
EtSubas
left a comment
There was a problem hiding this comment.
looks good from what I can see 👍
Jgerbrandt
left a comment
Jgerbrandt
left a comment
There was a problem hiding this comment.
garbage. how did this take you a whole semester.
…paceResearch/PlumbingBayBoard into ethan/thermocouple
|
Just a note: have to update telemetry task to request both a new sample and transmit for PT/TC. |
Matt4890
left a comment
Matt4890
left a comment
There was a problem hiding this comment.
A lot of styling inconsistencies/concerns, however that may not be critical. Be careful of magic numbers (i.e., just raw decimal numbers that aren't trivial). Instead, create a define/constexpr with a descriptive name and use that. This drastically improves code clarity and readability.
Otherwise, the functionality seems okay. Because of the massive architecture shift, I don't feel comfortable confirming that nothing is missing, so a super quick lookover from Chris/etc. would be nice.
Ensure that everything is functional before submitting.
AgamAulakh
left a comment
AgamAulakh
left a comment
There was a problem hiding this comment.
move to systemdefines.hpp
5 participants
adding in thermocouple task code along with debug info