Skip to content

Removed redundant resolution pick menu#499

Merged
Zewatara merged 1 commit into
developfrom
resolution
May 16, 2025
Merged

Removed redundant resolution pick menu#499
Zewatara merged 1 commit into
developfrom
resolution

Conversation

@Zewatara
Copy link
Copy Markdown
Contributor

@Zewatara Zewatara commented Nov 3, 2024

Summary

Removed the redundant resolution pick menu from the main-menu's scene settings.

Testing instructions

Open the Main Menu scene > run the game > Open settings > Check if there is only one resolution drop-down menu.

Additional information

  • [X] Changes UI
  • [ ] Introduces new feature
  • [ ] Removes existing feature
  • [x] Has associated resource:

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.77%. Comparing base (f6d1450) to head (109dee2).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #499   +/-   ##
========================================
  Coverage    87.77%   87.77%           
========================================
  Files           95       95           
  Lines         3206     3206           
========================================
  Hits          2814     2814           
  Misses         392      392           
Flag Coverage Δ
EditModeTests_Suites_Core 15.31% <ø> (ø)
EditModeTests_Suites_TextDecoder 16.12% <ø> (ø)
PlayModeTests_Suites_Playthrough 57.73% <ø> (ø)
PlayModeTests_Suites_Scenes 59.95% <ø> (ø)
PlayModeTests_Suites_Scripts 68.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Zewatara Zewatara enabled auto-merge (rebase) May 16, 2025 13:24
@Zewatara Zewatara disabled auto-merge May 16, 2025 13:24
Menu removed from the scene
@Zewatara Zewatara enabled auto-merge (rebase) May 16, 2025 13:50
@Zewatara Zewatara merged commit 7ea6d5d into develop May 16, 2025
26 checks passed
@Zewatara Zewatara deleted the resolution branch May 16, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Redundant resolution picker

2 participants