Skip to content

Updates Ink package#515

Merged
ViMaSter merged 1 commit into
developfrom
updates/inkle-package
Sep 10, 2025
Merged

Updates Ink package#515
ViMaSter merged 1 commit into
developfrom
updates/inkle-package

Conversation

@ViMaSter
Copy link
Copy Markdown
Member

@ViMaSter ViMaSter commented May 17, 2025

Summary

Inkle recently changed their package name and released a few updates. This PR changes the package to the new name and updates it from 1.1.1 to 1.2.1.

GitHub Actions Runs are flaky at the moment and some run failures seem to stem from the compileTimeout being ignored in batchMode:

  1. Open https://github.com/Studio-Lovelies/GG-JointJustice-Unity/actions/runs/15085544932/job/42409223588?pr=513#step:9:1877
  2. Select the cog icon at the top right and enable Show timestamps
    The context menu shown after clicking the cog icon
  3. Notice the timeout at Sat, 17 May 2025 14:51:08 GMT, while the step was started at Sat, 17 May 2025 14:48:17 GMT (less than 3 minutes)

Before I open a bug report on their package, I want to see if updating to the latest version resolves it.

Testing instructions

No gameplay changes; tests should succeed and the game can be completed as before.

Additional information

  • [ ] Changes UI
  • [ ] Introduces new feature
  • [ ] Removes existing feature
  • [ ] Has associated resource:

@ViMaSter ViMaSter force-pushed the updates/inkle-package branch from c31ef10 to 92202ca Compare May 17, 2025 15:40
@ViMaSter ViMaSter enabled auto-merge (rebase) May 17, 2025 15:40
@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.77%. Comparing base (c9969c0) to head (f7cdfbe).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #515       +/-   ##
============================================
+ Coverage    77.23%   87.77%   +10.54%     
============================================
  Files           95       95               
  Lines         3206     3206               
============================================
+ Hits          2476     2814      +338     
+ Misses         730      392      -338     
Flag Coverage Δ
EditModeTests_Suites_Core 15.31% <ø> (ø)
EditModeTests_Suites_TextDecoder 16.12% <ø> (ø)
PlayModeTests_Suites_Playthrough 57.73% <ø> (ø)
PlayModeTests_Suites_Scenes 59.95% <ø> (ø)
PlayModeTests_Suites_Scripts 68.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ViMaSter ViMaSter force-pushed the updates/inkle-package branch from 92202ca to d6ea766 Compare May 17, 2025 18:10
…nity-integration` `1.1.1` to `com.inkle.ink-unity-integration` `1.2.1`
@ViMaSter ViMaSter force-pushed the updates/inkle-package branch from d6ea766 to f7cdfbe Compare September 5, 2025 12:30
@ViMaSter ViMaSter merged commit 93487af into develop Sep 10, 2025
28 checks passed
@ViMaSter ViMaSter deleted the updates/inkle-package branch September 10, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants