Skip to content

Replace LFS with native Git integration#520

Merged
ViMaSter merged 4 commits into
developfrom
replace-lfs
Jun 23, 2025
Merged

Replace LFS with native Git integration#520
ViMaSter merged 4 commits into
developfrom
replace-lfs

Conversation

@ViMaSter
Copy link
Copy Markdown
Member

@ViMaSter ViMaSter commented Jun 23, 2025

Summary

GitHub has recently changed their LFS limits resulting in automated build failures.

This results 264.51 MB of change.

PowerShell used to calculate it:
# obtained from GitHub's diff viewer
$fileSizes = @(
    "+855 Bytes",
    "+13.3 MB",
    "+13.2 MB",
    "+13.3 MB",
    "+13.3 MB",
    "+13.4 MB",
    "+13.3 MB",
    "+13.2 MB",
    "+13.3 MB",
    "+13.3 MB",
    "+13.4 MB",
    "+2.27 MB",
    "+443 KB",
    "+3.33 MB",
    "+2.29 MB",
    "+1.81 MB",
    "+1.84 MB",
    "+1.19 MB",
    "+2.26 MB",
    "+5.25 MB",
    "+1.21 MB",
    "+1.81 MB",
    "+1.12 MB",
    "+2.85 MB",
    "+1.78 MB",
    "+1.31 MB",
    "+1.88 MB",
    "+1000 KB",
    "+3.44 MB",
    "+2.24 MB",
    "+1.97 MB",
    "+928 KB",
    "+1.63 MB",
    "+1.31 MB",
    "+779 KB",
    "+1.99 MB",
    "+1.47 MB",
    "+146 KB",
    "+626 KB",
    "+1.42 MB",
    "+2.12 MB",
    "+1.57 MB",
    "+885 KB",
    "+1.3 MB",
    "+1.02 MB",
    "+2.3 MB",
    "+1.94 MB",
    "+1.28 MB",
    "+1.91 MB",
    "+2.34 MB",
    "+2.39 MB",
    "+1.78 MB",
    "+2.5 MB",
    "+1.33 MB",
    "+3.23 MB",
    "+1.43 MB",
    "+1.49 MB",
    "+1.64 MB",
    "+1.47 MB",
    "+1.81 MB",
    "+1.53 MB",
    "+2.34 MB",
    "+1.03 MB",
    "+644 KB",
    "+1.22 MB",
    "+954 KB",
    "+2.13 MB",
    "+1.01 MB",
    "+1.21 MB",
    "+2.47 MB",
    "+1.1 MB",
    "+1.95 MB",
    "+2.25 MB",
    "+1.52 MB",
    "+1.75 MB",
    "+2.39 MB",
    "+445 KB",
    "+1.13 MB",
    "+1.51 MB",
    "+1.82 MB",
    "+1.13 MB",
    "+2.25 MB",
    "+719 KB",
    "+793 KB",
    "+1.15 MB",
    "+881 KB",
    "+1.81 MB",
    "+199 KB",
    "+1.45 KB",
    "+2.28 KB",
    "+13.6 KB",
    "+98.5 KB",
    "+12.7 KB",
    "+14.2 KB",
    "+30.1 KB",
    "+29.6 KB",
    "+6.91 KB",
    "+203 KB",
    "+6.78 KB",
    "+63.8 KB",
    "+788 Bytes",
    "+171 KB",
    "+10.9 KB",
    "+114 KB",
    "+114 KB",
    "+14.9 KB",
    "+127 KB",
    "+768 Bytes",
    "+265 KB",
    "+102 KB",
    "+89.7 KB",
    "+114 KB",
    "+56.4 KB",
    "+228 KB",
    "+113 KB",
    "+17.5 KB",
    "+666 KB",
    "+445 KB",
    "+18.9 KB",
    "+8.01 KB",
    "+763 KB",
    "+4.06 KB",
    "+1.04 KB",
    "+3.71 KB",
    "+25.3 KB",
    "+2.43 KB",
    "+7.71 KB",
    "+17.2 KB",
    "+23.7 KB",
    "+314 KB",
    "+7.06 KB",
    "+28.2 KB",
    "+25.6 KB",
    "+42.8 KB",
    "+114 KB",
    "+69.6 KB",
    "+25.3 KB",
    "+7.64 KB",
    "+11.4 KB",
    "+27.3 KB",
    "+7.75 KB",
    "+8.09 KB",
    "+8.29 KB",
    "+146 KB",
    "+203 KB",
    "+2.85 KB",
    "+45.9 KB",
    "+16.1 KB",
    "+4.61 KB",
    "+71.5 KB"
)

function ConvertToBytes($size) {
    if ($size -match "(\d+(\.\d+)?)\s*(Bytes|KB|MB|GB)") {
        $value = [double]$matches[1]
        switch ($matches[3]) {
            "Bytes" { return $value }
            "KB" { return $value * 1024 }
            "MB" { return $value * 1024 * 1024 }
            "GB" { return $value * 1024 * 1024 * 1024 }
        }
    }
    return 0
}

$totalBytes = $fileSizes | ForEach-Object { ConvertToBytes $_ } | Measure-Object -Sum
$totalBytes.Sum # = 277363716.6 Bytes

Testing instructions

Ensure tests pass and the game plays just like before.

Additional information

  • [ ] Changes UI
  • [ ] Introduces new feature
  • [ ] Removes existing feature
  • [ ] Has associated resource:

@ViMaSter ViMaSter marked this pull request as ready for review June 23, 2025 14:45
@ViMaSter ViMaSter marked this pull request as draft June 23, 2025 14:46
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.77%. Comparing base (d3d9c6f) to head (b4b2b2e).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #520   +/-   ##
========================================
  Coverage    87.77%   87.77%           
========================================
  Files           95       95           
  Lines         3206     3206           
========================================
  Hits          2814     2814           
  Misses         392      392           
Flag Coverage Δ
EditModeTests_Suites_Core 15.31% <ø> (ø)
EditModeTests_Suites_TextDecoder 16.12% <ø> (ø)
PlayModeTests_Suites_Playthrough 57.73% <ø> (ø)
PlayModeTests_Suites_Scenes 59.95% <ø> (ø)
PlayModeTests_Suites_Scripts 68.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ViMaSter ViMaSter marked this pull request as ready for review June 23, 2025 16:25
@ViMaSter ViMaSter enabled auto-merge (rebase) June 23, 2025 16:25
@ViMaSter ViMaSter merged commit c907225 into develop Jun 23, 2025
70 of 82 checks passed
@ViMaSter ViMaSter deleted the replace-lfs branch June 23, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants