Fix low-severity audit issues across codebase#5
Merged
ConsoleTVs merged 1 commit intomainfrom Apr 12, 2026
Merged
Conversation
- Correct BroadcastPayload.event type to template literal matching actual emitted values - Fix misleading JSDoc on keys(), HydrateOptions, Query.forget, defaultFetcher, and emit() - Fix spelling errors: immediatly, responsability, controll, dont, sale - Add missing readonly modifiers to QueryTransitionProps, HydrateOptions, MutateOptions - Align NextFunction type signature with implementation (add optional signal param) - Remove redundant Partial wrapper from ConfigureFunction type - Fix QueryPrefetchTags leaking query prop onto <link> elements - Fix duplicate/tautological assertion in once events test - Replace inert eslint-disable-next-line with oxlint-disable-next-line in 4 test files - Remove unnecessary 'as Error' casts in trigger error handling - Remove redundant skipDefaultLibCheck from tsconfig.base.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves 17 low-severity issues identified during the final audit pass. These are documentation fixes, type strictness improvements, spelling corrections, and minor code quality improvements. No behavioral changes.
Type Strictness (
options.ts)BroadcastPayload.eventfromQueryEventto`${QueryEvent}:${string}`to match actual emitted valuessignal?: AbortSignalparam toNextFunctiontype to match implementationPartial<>wrapper fromConfigureFunction(allConfigurationproperties are already optional)readonlymodifiers toHydrateOptions.expirationandMutateOptions.expirationDocumentation Fixes (
query.ts,options.ts)keys()(said "Determines if the given key is currently resolving")HydrateOptionsJSDoc (copy-paste said "The mutate function options")Query.forgetJSDoc (incorrectly claimed it removes from both caches)emitJSDoc typo: "with case" → "with care"defaultFetcherJSDoc: "Stores" → "Creates"immediatly(3x),responsability(1x),controll(1x),dont(1x)Code Quality
QueryPrefetchTagsleakingqueryprop onto<link>HTML elements via rest spreadas Errortype casts intrigger()error handlingreadonlyto allQueryTransitionPropsinterface properties for consistencyTest Quality (
query.test.ts, 4 React test files)expect(event).toBeDefined()assertion — second one now checksexpect(event.detail).toBe('works')eslint-disable-next-linecomments withoxlint-disable-next-line(project uses OxLint)Configuration (
tsconfig.base.json)skipDefaultLibCheck(already covered byskipLibCheck: true)