[codex] Add block range annotations design doc#332
Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc926782f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <p>Each comment thread root is a block with a dedicated type, a deterministic annotation-container parent, and a small property payload.</p> | ||
|
|
||
| <pre><code>parentId: "annotation-container-for-workspace" | ||
| types: ["annotation:thread"] |
There was a problem hiding this comment.
When the v1 code follows this example, the annotation thread won't be discoverable by type because this repo does not have a top-level types field: BlockData exposes only properties, and the block_types index is populated from properties_json.$.types (src/data/internals/clientSchema.ts). Please show "types" inside the properties payload (encoded via typesProp) so creation/query code writes the field that existing type queries actually index.
Useful? React with 👍 / 👎.
1 participant
Summary
Why
This records the design direction for Google Docs-style comments over selected block text before implementation work starts. The core architectural call is to keep comment threads as normal blocks while storing anchors as separate block-local selector payloads, with highlights derived in the UI.
Validation
yarn run check