Skip to content

fix(renderers): warn on missing renderer override#97

Open
ai-hustle-bro wants to merge 1 commit into
Stvad:masterfrom
ai-hustle-bro:codex/warn-missing-renderer
Open

fix(renderers): warn on missing renderer override#97
ai-hustle-bro wants to merge 1 commit into
Stvad:masterfrom
ai-hustle-bro:codex/warn-missing-renderer

Conversation

@ai-hustle-bro

Copy link
Copy Markdown

Fixes #82.

Summary

  • warn when rendererProp names a renderer id that is not present in the registry
  • include the requested renderer id and the available registry ids in the warning
  • preserve the existing fallback behavior by continuing through canRender/priority/default renderer selection
  • split renderer resolution into a testable helper and cover registered vs missing override paths

Validation

  • corepack yarn vitest run src/hooks/useRendererRegistry.test.ts
  • ./node_modules/.bin/tsc.cmd -b
  • corepack yarn eslint src/hooks/useRendererRegistry.tsx src/hooks/useRendererRegistry.test.ts

Note: corepack yarn compile passes the TypeScript build step on this Windows checkout, then fails at the final Unix-only chmod +x ... command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rendererProp silently no-ops on a misspelled / unregistered renderer id

2 participants