Fix precursor proximity triggers not reacting to remote players#2649
Open
misterbubb wants to merge 6 commits into
Open
Fix precursor proximity triggers not reacting to remote players#2649misterbubb wants to merge 6 commits into
misterbubb wants to merge 6 commits into
Conversation
…rox#2643) - Add patches for PrecursorActivatedPillar (ion cube pedestals with ion cube on top) - Add patches for PrecursorKeyTerminalTrigger (tablet pedestals) - Track player count to prevent closing when other players are still nearby - Only play sounds when first player enters (prevents duplicate sounds) - Pedestals only close when ALL players have left the trigger zone
Test Results255 tests +9 252 ✅ +7 10s ⏱️ +3s Results for commit 7c6289c. ± Comparison against base commit a0de9db. This pull request removes 10 and adds 19 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Coding-Hen
reviewed
Jan 15, 2026
misterbubb
changed the title
The player ping signal prefab has a SphereCollider with radius 10 that was triggering proximity events (like precursor pedestals) before the player's actual CapsuleCollider. This caused remote players to trigger pedestals from ~8m away instead of the intended ~3m. Disabling the SphereCollider on the signal prevents this issue while keeping the ping functionality intact.
Coding-Hen
reviewed
Jan 17, 2026
Coding-Hen
approved these changes
Feb 23, 2026
Collaborator
Coding-Hen
left a comment
Coding-Hen
left a comment
There was a problem hiding this comment.
LGCW I think in game it would be good to check the colliders though when we do a test session
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2643
Changes
PrecursorActivatedPillar(ion cube pedestals)PrecursorKeyTerminalTrigger(tablet pedestals)PrecursorDisableGunTerminalArea(gun disable terminal)