Skip to content

fix: SetFullAccessToCurrentUser on macOS/Linux + local .nitrox-dev gitignore#2692

Merged
Measurity merged 4 commits into
SubnauticaNitrox:masterfrom
jtywork:fix/unix-filesystem-permissions
May 10, 2026
Merged

fix: SetFullAccessToCurrentUser on macOS/Linux + local .nitrox-dev gitignore#2692
Measurity merged 4 commits into
SubnauticaNitrox:masterfrom
jtywork:fix/unix-filesystem-permissions

Conversation

@jtywork
Copy link
Copy Markdown
Contributor

@jtywork jtywork commented Mar 22, 2026

Summary

  • Gitignore .nitrox-dev/ for local-only dev notes.
  • Implement SetFullAccessToCurrentUser on macOS and Linux via chmod -R u+rwX (shared PosixFileSystemPermissions helper, net472-safe Arguments string).
  • Add MacFileSystemTest and UnixFileSystemTest using [OSTestMethod] (skip on non-matching OS).

Test plan

  • dotnet test Nitrox.Test — Mac tests pass on macOS; Linux tests inconclusive locally.

Made with Cursor

jtywork added 2 commits March 22, 2026 14:16
Use chmod -R u+rwX via shared PosixFileSystemPermissions helper.
Add Mac and Linux platform tests (OSTestMethod).

Made-with: Cursor
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 22, 2026

Test Results

255 tests  +16   252 ✅ +14   8s ⏱️ -4s
  1 suites ± 0     3 💤 + 2 
  1 files   ± 0     0 ❌ ± 0 

Results for commit b1f6698. ± Comparison against base commit d67d4f7.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Member

@Jannify Jannify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that one comment looks good imo

Comment thread .gitignore Outdated
.DS_Store

# Local development documentation (not committed)
.nitrox-dev/
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this folder? Can't it be located outside the repo?

@CherrieTheShifter

This comment was marked as spam.

@dartasen dartasen requested a review from Measurity May 9, 2026 18:24
Measurity added 2 commits May 10, 2026 03:13
Not used by rest of team. Development documentation should go on the docs website or as xmldoc on related APIs.
@Measurity Measurity merged commit b8fd6f5 into SubnauticaNitrox:master May 10, 2026
2 checks passed
@dartasen dartasen added this to the 1.8.2.0 milestone May 17, 2026
@dartasen dartasen added OS: MacOS OS: Linux Area: setup Related to installing, configuring or how compatible Nitrox is with other tools labels May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: setup Related to installing, configuring or how compatible Nitrox is with other tools OS: Linux OS: MacOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Launcher v1.8.0.0 crashed with System.NotImplementedException: The method or operation is not implemented.

5 participants