Skip to content

Fixed gamepass launch failing if there are spaces in the path#2736

Open
Measurity wants to merge 5 commits into
SubnauticaNitrox:masterfrom
Measurity:fix-gamepass-launch
Open

Fixed gamepass launch failing if there are spaces in the path#2736
Measurity wants to merge 5 commits into
SubnauticaNitrox:masterfrom
Measurity:fix-gamepass-launch

Conversation

@Measurity
Copy link
Copy Markdown
Collaborator

@Measurity Measurity commented May 15, 2026

Needs testing with game pass version of the game!

CMD start docs

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

Test Results

255 tests  ±0   252 ✅ ±0   10s ⏱️ -1s
  1 suites ±0     3 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 9178fd9. ± Comparison against base commit 22cf75e.

♻️ This comment has been updated with latest results.

@Measurity Measurity added this to the 1.9 milestone May 15, 2026
Comment thread Nitrox.Model/Platforms/Store/MSStore.cs Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Microsoft Store launch command to quote the path to the game executable so that paths containing spaces (typical for Game Pass installations under C:\Program Files\WindowsApps\...) are handled correctly by cmd /C start /b. The change converts the interpolated arg string from a verbatim-interpolated string to a raw-interpolated string and adds quotes around pathToGameExe and the --nitrox <launcherPath> <args> group.

Changes:

  • Switch from @$"..." verbatim interpolation to $"""...""" raw interpolation for the cmd argument.
  • Wrap {pathToGameExe} in double quotes to support spaces in the path.
  • Wrap the --nitrox argument block in quotes and use single quotes around the launcher path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Nitrox.Model/Platforms/Store/MSStore.cs Outdated
@dartasen dartasen requested a review from Copilot May 15, 2026 22:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@Measurity Measurity modified the milestones: 1.9, 1.8.2.0 May 17, 2026
@Measurity
Copy link
Copy Markdown
Collaborator Author

Anyone with gamepass that can test this PR for me? 🥺

@dartasen dartasen added the Status: Needs testing Pull Request is waiting for testing label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants