Add Discord SDK crash fallback#2756
Open
mindless2831 wants to merge 1 commit into
Open
Conversation
83217a8 to
b98bd95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Discord SDK crash fallback for game launch.
Fixes #2708.
What changed
This PR adds two protections for users affected by native Discord SDK crashes during Nitrox startup:
DiscordClientwhen Discord integration is disabled.Player.logcontains the known Discord SDK crash signatures, the launcher relaunches Subnautica once with Discord integration disabled.Why
The crash in #2708 occurs inside the native Discord SDK path around Rich Presence initialization/update:
discord_game_sdkDiscordClient.InitializeRPMenuDiscordClient.UpdateActivityDiscordGameSDKWrapper.ActivityManager.UpdateActivityBecause this is a native crash, managed try/catch inside the client is not reliable. The safer fallback is to relaunch without initializing Discord integration.
Testing
Tested manual Discord integration toggle:
[Discord] Discord integration disabled by launch argumentTested fallback behavior using a local test-only forced detection path:
[Discord] Discord integration disabled by launch argumentThe forced test hook was removed before this PR.
Also tested normal early game exit without a current Discord crash signature; the launcher does not relaunch.