Merge pull request #12071 from SubtitleEdit/fix/batchconvert-persist-on-close

niksedk · web-flow · commit c36a34eb1901 · 2026-07-02T14:41:27.000+02:00
BatchConvert: persist settings when window is closed via X/Escape
diff --git a/src/ui/Features/Tools/BatchConvert/BatchConvertViewModel.cs b/src/ui/Features/Tools/BatchConvert/BatchConvertViewModel.cs
@@ -2504,6 +2504,11 @@ internal void Onloaded(object? sender, RoutedEventArgs e)
     internal void OnClosing(object? sender, WindowClosingEventArgs e)
     {
         UiUtil.SaveWindowPosition(Window);
+
+        // Persist target format and function options also when the window is closed via
+        // X/Escape - especially important in /batchconvertui mode, where this window is the
+        // main window and nothing else flushes settings to disk on exit (#11699).
+        SaveSettings();
     }
 
     internal void ComboBoxSubtitleFormatChanged()

Original file line number	Diff line number	Diff line change
`@@ -2504,6 +2504,11 @@ internal void Onloaded(object? sender, RoutedEventArgs e)`
`2504`	`2504`	`internal void OnClosing(object? sender, WindowClosingEventArgs e)`
`2505`	`2505`	`{`
`2506`	`2506`	`UiUtil.SaveWindowPosition(Window);`
	`2507`	`+`
	`2508`	`+ // Persist target format and function options also when the window is closed via`
	`2509`	`+ // X/Escape - especially important in /batchconvertui mode, where this window is the`
	`2510`	`+ // main window and nothing else flushes settings to disk on exit (#11699).`
	`2511`	`+ SaveSettings();`
`2507`	`2512`	`}`
`2508`	`2513`
`2509`	`2514`	`internal void ComboBoxSubtitleFormatChanged()`