Fix original-subtitle dirty hash using object ToString instead of file name#12070
Merged
Conversation
…e name GetFastHashOriginal concatenated the _subtitleOriginal Subtitle object (whose ToString is constant) instead of _subtitleFileNameOriginal, so the original file name never contributed to the change-detection hash, unlike GetFastHash which uses _subtitleFileName. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetFastHashOriginalbuilt its prefix with_subtitleOriginal + SelectedEncoding.DisplayName— string-concatenating theSubtitleobject, whose defaultToString()is constant — instead of_subtitleFileNameOriginal. So the original subtitle's file name never contributed to the change-detection hash, unlikeGetFastHash, which correctly uses_subtitleFileName.One-line fix: use
_subtitleFileNameOriginal, mirroringGetFastHash.Found while profiling the slow-timer hash passes in the performance review (#12069).
🤖 Generated with Claude Code