Skip to content

BatchConvert: persist settings when window is closed via X/Escape #12071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niksedk merged 1 commit into from
Jul 2, 2026
+5 −0
Merged

BatchConvert: persist settings when window is closed via X/Escape #12071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/ui/Features/Tools/BatchConvert/BatchConvertViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2504,6 +2504,11 @@ internal void Onloaded(object? sender, RoutedEventArgs e)
internal void OnClosing(object? sender, WindowClosingEventArgs e)
{
UiUtil.SaveWindowPosition(Window);

// Persist target format and function options also when the window is closed via
// X/Escape - especially important in /batchconvertui mode, where this window is the
// main window and nothing else flushes settings to disk on exit (#11699).
SaveSettings();
}

internal void ComboBoxSubtitleFormatChanged()
Expand Down