Actually notify errors (#270)

BryceStevenWilley · web-flow · commit e3d116444813 · 2025-07-21T18:12:33.000-04:00
`error_notification`, the function called from `log_error_and_notify`
that sends an email to the docassemble error email in the config, had
been broken, silently, since nothing was logging in the `try: except`
blocks. Started logging those issues, and fixed them locally.

Also:

* Removed `the_vars`, which was causing the error (couldn't open the tmp
json
file), so we won't get the full interview context with the emails
(should
  be okay)
* Send that email error notification if the user fails to login for any
reason
  (besides a 403) 
* Replaced the `bad_fees` screen with our standard bug screen. That's
one of the few screens that's a hard block on E-filing interviews, and
is more confusing to users than otherwise. It's better to just say
"something went wrong" and give them their options (should make sure
they're able to download their forms at that point, but that's a
separate thing).
diff --git a/docassemble/EFSPIntegration/conversions.py b/docassemble/EFSPIntegration/conversions.py
@@ -12,6 +12,7 @@
     DAObject,
     DADateTime,
     as_datetime,
+    current_context,
     validation_error,
     log,
     as_datetime,
@@ -49,7 +50,7 @@
 TypeType = type(type(None))
 
 
-def error_notification(err, message=None, trace=None, referer=None, the_vars=None):
+def error_notification(err, message=None, trace=None, referer=None):
     """Copied from docassemble.webapp.server.error_notification, since:
     1) things from webapp.* are unstable
     2) it breaks the unit tests and the mypy
@@ -79,31 +80,6 @@ def error_notification(err, message=None, trace=None, referer=None, the_vars=Non
         email_address = user_info().email
     except:
         email_address = None
-    referer = None
-    if get_config("error notification variables", get_config("debug", True)):
-        if the_vars is None:
-            try:
-                the_vars = docassemble.base.functions.all_variables(
-                    include_internal=True
-                )
-            except:
-                pass
-    else:
-        the_vars = None
-    json_filename = None
-    if the_vars is not None and len(the_vars):
-        try:
-            with tempfile.NamedTemporaryFile(
-                mode="w",
-                prefix="datemp",
-                suffix=".json",
-                delete=False,
-                encoding="utf-8",
-            ) as fp:
-                fp.write(json.dumps(the_vars, sort_keys=True, indent=2))
-                json_filename = fp.name
-        except:
-            pass
     interview_path = docassemble.base.functions.interview_path()
     try:
         try:
@@ -152,29 +128,28 @@ def error_notification(err, message=None, trace=None, referer=None, the_vars=Non
             html += "\n  </body>\n</html>"
             log(f"Trying to send error message {body}")
             send_email(
-                subject=appname + " error: " + err.__class__.__name,
+                subject=appname + " error: " + err.__class__.__name__,
                 to=email_recipients,
                 body=body,
                 html=html,
-                attachments=[json_filename],
             )
         except Exception as zerr:
-            log(str(zerr))
+            log(f"Failed to send original message: {zerr}")
             body = "There was an error in the " + appname + " application."
             html = (
                 "<html>\n  <body>\n    <p>There was an error in the "
                 + appname
                 + " application.</p>\n  </body>\n</html>"
             )
-            log(f"Trying to send error message {body}")
+            log(f"Trying to send (lesser) error message {body}")
             send_email(
                 subject=appname + " error: " + err.__class__.__name__,
                 to=email_recipients,
                 body=body,
                 html=html,
-                attachments=[json_filename],
             )
-    except:
+    except Exception as all_err:
+        log(f"Big ol err: {all_err}")
         pass
 
 
@@ -183,7 +158,7 @@ def log_error_and_notify(context: str, resp: Optional[ApiResponse] = None):
     the `error_notification_email` in the config."""
     message = f"context: {context};; resp: {resp}"
     log(f"EFSPIntegration ERROR: {message}")
-    error_notification(resp, message=message)
+    error_notification(resp, message=message, referer=current_context().filename)
 
 
 def convert_court_to_id(trial_court) -> str:
diff --git a/docassemble/EFSPIntegration/data/questions/efiling_integration.yml b/docassemble/EFSPIntegration/data/questions/efiling_integration.yml
@@ -892,15 +892,6 @@ subquestion: |
   There are no fees associated with this filing.
 continue button field: review_fees_screen
 ---
-id: bad fees
-event: bad_fees
-question: |
-  Something went wrong
-subquestion: |
-  Sorry, something went wrong when trying to figure out if you have to pay fees.
- 
-  More details: ${ debug_display(fees_resp) }
----
 depends on:
   - fees_resp
 code: |
@@ -940,7 +931,7 @@ code: |
   if fees_resp.is_ok():
     review_fees_screen
   else:
-    bad_fees
+    raise Exception(f"Was not able to calculate fees: {fees_resp}")
   review_fees = True
 ---
 #############################
diff --git a/docassemble/EFSPIntegration/data/questions/login_qs.yml b/docassemble/EFSPIntegration/data/questions/login_qs.yml
@@ -45,7 +45,10 @@ code: |
     tyler_login_resp = proxy_conn.authenticate_user(tyler_email=my_username, tyler_password=my_password)
     del my_password
     if not tyler_login_resp.is_ok():
-      log(f'Failed to login: {tyler_login_resp}')
+      if int(tyler_login_resp.response_code) != 403:
+        log_error_and_notify('Failed to login', tyler_login_resp)
+      else:
+        log(f'Failed to login: {tyler_login_resp}')
       login_failed_screen
     else:
       log(word("You are now connected to your e-filing account"), "primary")
