Skip to content

Commit e6e2dd9

Browse files
Integration test improvements (#267)
* Randomized the emails we use to make accounts * Factored out variables needed for different jurisdictions (MA vs IL, etc.) (not completely done, need a json to make a filing into MA still) * switched to `unittest`: easier to understand the half-baked self-rolled assertions that stop immediately * changed the account env vars to be reasonable (no assumptions of the account, better env var name)
1 parent dd6b652 commit e6e2dd9

5 files changed

Lines changed: 161 additions & 192 deletions

File tree

.github/workflows/integration_test.yml

Lines changed: 0 additions & 22 deletions
This file was deleted.

.github/workflows/unittests.yml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,24 @@
1-
name: Run python only unit tests and mypy
1+
name: Run mypy and python-only unit and integration tests
22

33
on:
44
push:
55
workflow_dispatch:
66

7+
env:
8+
PROXY_URL: https://efile-test.suffolklitlab.org
9+
PROXY_API_KEY: ${{ secrets.EFILE_PROXY_API_KEY }}
10+
TYLER_USER_EMAIL: ${{ secrets.TYLER_EMAIL }}
11+
TYLER_USER_PASSWORD: ${{ secrets.TYLER_PASSWORD }}
12+
13+
# Allow only one concurrent test-run, skipping runs queued between the run in-progress and latest queued.
14+
# However, do NOT cancel in-progress runs as stopping integration tests mid-run could end up in a bad state
15+
concurrency:
16+
group: "tests"
17+
cancel-in-progress: false
18+
719
jobs:
820
test-efspintegration:
921
runs-on: ubuntu-latest
10-
name: Run python only unit tests
22+
name: Run python-only unit and integration tests
1123
steps:
1224
- uses: SuffolkLITLab/ALActions/pythontests@main

docassemble/EFSPIntegration/conversions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@ def chain_xml(xml_val, elems: List[Union[str, int]]):
408408
val = xml_val
409409
for idx, elem in enumerate(elems):
410410
if not val:
411-
log(f"No {elem} ({idx}) in {xml_val} ({elems})")
411+
log(f"No `{elem}` ({idx}) in `{xml_val}` ({elems})")
412412
return None
413413
if isinstance(val, dict):
414414
val = val.get(elem) or {}

0 commit comments

Comments
 (0)