Skip to content

Commit e91771f

Browse files
Don't depend on `declaredType'
Directly couples us to the full java package namespace, which is not good (there have been refactors that are out in efile-test now that break the assumption that the package names won't change). Instead, use `name` (which is the XML Schema name), or just check that the `declaredType` contains the path we expect (those refactors only add to the namespace, not changing it entirely).
1 parent c4210f3 commit e91771f

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

docassemble/EFSPIntegration/conversions.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -261,19 +261,19 @@ def pretty_display(data, tab_depth=0, skip_xml=True, item_name=None) -> str:
261261

262262
elif isinstance(data, dict):
263263
if "declaredType" in data:
264-
if data["declaredType"] == "gov.niem.niem.niem_core._2.TextType":
264+
if "gov.niem.niem.niem_core._2.TextType" in data["declaredType"]:
265265
out += (
266266
tab_str
267267
+ f"* {data['name'].replace(':', '/')}: {data['value']['value']}\n"
268268
)
269269
return out
270-
if data["declaredType"] == "gov.niem.niem.proxy.xsd._2.Boolean":
270+
if "gov.niem.niem.proxy.xsd._2.Boolean" in data["declaredType"]:
271271
out += (
272272
tab_str
273273
+ f"* {data['name'].replace(':', '/')}: {data['value']['value']}\n"
274274
)
275275
return out
276-
if data["declaredType"] == "gov.niem.niem.proxy.xsd._2.DateTime":
276+
if "gov.niem.niem.proxy.xsd._2.DateTime" in data["declaredType"]:
277277
out += (
278278
tab_str
279279
+ f"* date: {datetime.fromtimestamp(float(data['value']['value'])/1000)}\n"
@@ -765,8 +765,8 @@ def fetch_case_info(
765765
new_case.lower_docket_number = aug.get("value", {}).get("caseDocketID")
766766
new_case.lower_case_title = aug.get("value", {}).get("caseTitleText")
767767
if (
768-
aug.get("declaredType")
769-
== "tyler.ecf.extensions.common.CaseAugmentationType"
768+
aug.get("name")
769+
== r"{urn:tyler:ecf:extensions:Common}CaseAugmentation"
770770
):
771771
new_case.lower_judge = aug.get("value", {}).get("lowerCourtJudgeText")
772772
participant_xml = aug.get("value", {}).get("caseParticipant", [])

0 commit comments

Comments
 (0)