Fix attribute issue#280
Merged
Merged
Conversation
Forgot that in docassemle, you can't assume your objects will be correctly initialized, and should do it on the fly. Fixed this issue for `session_id` and `logger`, the two attributes that were added in #274. Have to handle the session ID in just the parent class (`EfspConnection`), but need to handle the logger in both the parent and child class (`ProxyConnection`). (Have to have the methods in the parent class at all because the child class because the parent class would have the same issues. This makes separating out a full python client more complicated than I realized unfortunately Reintegrating myself into the world of DA, one fix at a time).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Tested locally on interviews started with 1.6.0, and upgraded to this instead of 1.7.0).
Forgot that in docassemle, you can't assume your objects will be correctly initialized, and should do it on the fly.
Fixed this issue for
session_idandlogger, the two attributes that were added in #274. Have to handle the session ID in just the parent class (EfspConnection), but need to handle the logger in both the parent and child class (ProxyConnection).(Have to have the methods in the parent class at all because the child class because the parent class would have the same issues. This makes separating out a full python client more complicated than I realized unfortunately
Reintegrating myself into the world of DA, one fix at a time).