Skip to content

Warn when no codes match the given filters #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BryceStevenWilley merged 1 commit into from
Aug 18, 2025
Merged

Warn when no codes match the given filters #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docassemble/EFSPIntegration/interview_logic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,8 +458,14 @@ def filter_codes(
if len(codes) == 1:
return codes, codes[0][0]
elif len(codes) == 0:
log_error_and_notify(
f"Warning! No existing codes matched filters ({filters})! Falling back to default, but this is unchecked and dangerous. It will be removed in the future. (all of the options: {options})"
)
return list(options), default
else:
log(
f"Warning! More than one code matched filters ({filters})! This can result in a worse UX for users. (the found options ({codes}))"
)
return codes, None


Expand Down