Skip to content

Commit 92e9bba

Browse files
authored
Merge pull request #2 from SumedhSankhe/docker-workflow
update image size workflow
2 parents de88913 + 2fba0ea commit 92e9bba

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

.github/workflows/docker-build-push.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,20 +117,23 @@ jobs:
117117

118118
- name: Pull all images and compare sizes
119119
run: |
120+
# Lowercase the image name (Docker registry requires lowercase)
121+
IMAGE_NAME_LOWER=$(echo "${{ env.IMAGE_NAME }}" | tr '[:upper:]' '[:lower:]')
122+
120123
echo "## Docker Image Size Comparison" >> $GITHUB_STEP_SUMMARY
121124
echo "" >> $GITHUB_STEP_SUMMARY
122125
echo "| Variant | Size | Optimization |" >> $GITHUB_STEP_SUMMARY
123126
echo "|---------|------|--------------|" >> $GITHUB_STEP_SUMMARY
124127
125128
# Pull and get sizes
126-
docker pull ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:single-stage-latest || true
127-
docker pull ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:two-stage-latest || true
128-
docker pull ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:three-stage-latest || true
129+
docker pull ${{ env.REGISTRY }}/${IMAGE_NAME_LOWER}:single-stage-latest || true
130+
docker pull ${{ env.REGISTRY }}/${IMAGE_NAME_LOWER}:two-stage-latest || true
131+
docker pull ${{ env.REGISTRY }}/${IMAGE_NAME_LOWER}:three-stage-latest || true
129132
130133
# Get sizes
131-
SINGLE_SIZE=$(docker images --format "{{.Size}}" ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:single-stage-latest 2>/dev/null || echo "N/A")
132-
TWO_SIZE=$(docker images --format "{{.Size}}" ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:two-stage-latest 2>/dev/null || echo "N/A")
133-
THREE_SIZE=$(docker images --format "{{.Size}}" ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:three-stage-latest 2>/dev/null || echo "N/A")
134+
SINGLE_SIZE=$(docker images --format "{{.Size}}" ${{ env.REGISTRY }}/${IMAGE_NAME_LOWER}:single-stage-latest 2>/dev/null || echo "N/A")
135+
TWO_SIZE=$(docker images --format "{{.Size}}" ${{ env.REGISTRY }}/${IMAGE_NAME_LOWER}:two-stage-latest 2>/dev/null || echo "N/A")
136+
THREE_SIZE=$(docker images --format "{{.Size}}" ${{ env.REGISTRY }}/${IMAGE_NAME_LOWER}:three-stage-latest 2>/dev/null || echo "N/A")
134137
135138
echo "| Single-stage | ${SINGLE_SIZE} | Baseline |" >> $GITHUB_STEP_SUMMARY
136139
echo "| Two-stage | ${TWO_SIZE} | ~40% smaller |" >> $GITHUB_STEP_SUMMARY

0 commit comments

Comments
 (0)