fix: align default quality gates and validator signal semantics

Set wrong-solution-kill gate default to opt-in and treat skipped validator checks as not executed so verification signals and pack gating stay consistent with intended workflow behavior.

Made-with: Cursor

Author: SummerOneTwo

scripts/workflow_guard.py

@@ -15,7 +15,7 @@
     "require_validation_passed": True,
     "require_tests_verified": True,
     "require_limit_semantics": True,
-    "require_wrong_solution_kill": True,
+    "require_wrong_solution_kill": False,
     "require_validator_check": True,
     "min_limit_case_ratio": 0.5,
 }

src/autocode_mcp/templates/autocode.json

@@ -14,7 +14,7 @@
     "require_validation_passed": true,
     "require_tests_verified": true,
     "require_limit_semantics": true,
-    "require_wrong_solution_kill": true,
+    "require_wrong_solution_kill": false,
     "require_validator_check": true,
     "min_limit_case_ratio": 0.5
   },

src/autocode_mcp/tools/test_verify.py

@@ -245,6 +245,8 @@ def _build_quality_signals(self, verify_types: list[str], results: dict) -> dict
         for verify_name, signal_name in signal_map.items():
             result = results.get(verify_name)
             executed = verify_name in verify_set and isinstance(result, dict)
+            if executed and bool(result.get("skipped", False)):
+                executed = False
             signals[signal_name] = {
                 "executed": executed,
                 "passed": bool(result.get("passed")) if executed else False,

src/autocode_mcp/workflow/models.py

@@ -27,7 +27,7 @@ class QualityGates(BaseModel):
     require_validation_passed: bool = True
     require_tests_verified: bool = True
     require_limit_semantics: bool = True
-    require_wrong_solution_kill: bool = True
+    require_wrong_solution_kill: bool = False
     require_validator_check: bool = True
     min_limit_case_ratio: float = Field(default=0.5, ge=0, le=1)
 

tests/test_workflow_guard.py

@@ -156,6 +156,9 @@ def test_pre_tool_denies_interactive_generator_before_interactor(tmp_path, capsy
         "interactive": True,
         "sol_built": True,
         "brute_built": True,
+        "solution_analyzed": True,
+        "std_audited": True,
+        "brute_audited": True,
         "interactor_ready": False,
     }
     module.save_state(str(problem_dir), state)
@@ -171,10 +174,7 @@ def test_pre_tool_denies_interactive_generator_before_interactor(tmp_path, capsy
     assert exit_code == 0
     parsed = json.loads(captured)
     assert parsed["hookSpecificOutput"]["permissionDecision"] == "deny"
-    assert (
-        "interactor_build" in parsed["hookSpecificOutput"]["permissionDecisionReason"]
-        or "solution_analyze" in parsed["hookSpecificOutput"]["permissionDecisionReason"]
-    )
+    assert "interactor_build" in parsed["hookSpecificOutput"]["permissionDecisionReason"]
 
 
 def test_pre_tool_denies_pack_before_tests_verified(tmp_path, capsys):
@@ -430,7 +430,7 @@ def test_pre_tool_enforces_solution_audits_before_generator_build(tmp_path, caps
     captured = capsys.readouterr().out
     parsed = json.loads(captured)
     assert parsed["hookSpecificOutput"]["permissionDecision"] == "deny"
-    assert "solution_audit_std" in parsed["hookSpecificOutput"]["permissionDecisionReason"]
+    assert "solution_audit_brute" in parsed["hookSpecificOutput"]["permissionDecisionReason"]
 
 
 def test_pre_tool_pack_respects_quality_gate_override(tmp_path, capsys):