Cobord/chore/cleanup0#96
Draft
Cobord wants to merge 11 commits into
Draft
Conversation
…to reduce the number of fields in SummonerClient, especially in light of the slight mismatches between how things are called in config_dicts vs as fields of the client
…the underlying issues or document why they are not a problem
…ionality of _dna... into own file, so client.py can be simplified by continuing this process, removed all the type ignores for their specific reasons with explanations of why they do not matter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mix of familiarizing and useful changes. So this is just draft and can select which parts to keep for an actual PR