Skip to content

Line up web view taps #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SunkenInTime wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Line up web view taps #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09b9fc6
Fix YouTube webview gesture conflicts in media carousel
cursoragent Mar 6, 2026
09db4b6
Fix missing Factory import for webview gesture recognizer
cursoragent Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/widgets/youtube_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import 'dart:developer' show log;

import 'package:flutter/foundation.dart' show Factory;
import 'package:flutter/gestures.dart';
import 'package:flutter/material.dart';
import 'package:flutter_inappwebview/flutter_inappwebview.dart';
import 'package:icarus/const/youtube_handler.dart';
Expand Down Expand Up @@ -49,10 +51,16 @@ class _YoutubeViewState extends State<YoutubeView>
with AutomaticKeepAliveClientMixin {
@override
bool get wantKeepAlive => true;
static final Set<Factory<OneSequenceGestureRecognizer>>
_youtubeGestureRecognizers = {
Factory<OneSequenceGestureRecognizer>(() => EagerGestureRecognizer()),
};

@override
Widget build(BuildContext context) {
super.build(context);
final videoId =
YoutubeHandler.extractYoutubeIdWithTimestamp(widget.youtubeLink);

if (!isWebViewInitialized) {
// showShadDialog<void>(
Expand All @@ -71,6 +79,7 @@ class _YoutubeViewState extends State<YoutubeView>
),
Positioned.fill(
child: InAppWebView(
gestureRecognizers: _youtubeGestureRecognizers,
onLoadStart: (controller, url) {
log("Youtube view loading");
},
Expand All @@ -81,8 +90,7 @@ class _YoutubeViewState extends State<YoutubeView>
initialSettings:
InAppWebViewSettings(allowBackgroundAudioPlaying: false),
initialUrlRequest: URLRequest(
url: WebUri(
"https://embed.icarus-strats.xyz/?v=${YoutubeHandler.extractYoutubeIdWithTimestamp(widget.youtubeLink)}")),
url: WebUri("https://embed.icarus-strats.xyz/?v=$videoId")),
),
),
],
Expand Down