fix(vm): correct osaka proposal id, default config and modexp behavior

1. Change ALLOW_TVM_OSAKA proposal id from 95 to 96
2. DynamicPropertiesStore.getAllowTvmOsaka() defaults to CommonParameter
3. ModExp returns Pair.of(false, EMPTY_BYTE_ARRAY) instead of throwing
   PrecompiledContractException when inputs exceed 1024 bytes, matching
   geth/besu behavior where only the CALL fails (not the whole tx)
4. Update test to verify return value instead of catching exception

Author: ouy95917

actuator/src/main/java/org/tron/core/utils/ProposalUtil.java

@@ -971,7 +971,7 @@ public enum ProposalType {         // current value, value range
     ALLOW_TVM_BLOB(89), // 0, 1
     PROPOSAL_EXPIRE_TIME(92), // (0, 31536003000)
     ALLOW_TVM_SELFDESTRUCT_RESTRICTION(94), // 0, 1
-    ALLOW_TVM_OSAKA(95); // 0, 1
+    ALLOW_TVM_OSAKA(96); // 0, 1
 
     private long code;
 

actuator/src/main/java/org/tron/core/vm/PrecompiledContracts.java

@@ -65,7 +65,6 @@
 import org.tron.core.capsule.TransactionCapsule;
 import org.tron.core.capsule.WitnessCapsule;
 import org.tron.core.db.TransactionTrace;
-import org.tron.core.exception.TronException;
 import org.tron.core.exception.ZksnarkException;
 import org.tron.core.vm.config.VMConfig;
 import org.tron.core.vm.program.Program;
@@ -663,10 +662,9 @@ public Pair<Boolean, byte[]> execute(byte[] data) {
       int expLen = parseLen(data, 1);
       int modLen = parseLen(data, 2);
 
-      if (VMConfig.allowTvmOsaka() &&
-          (baseLen > UPPER_BOUND || expLen > UPPER_BOUND || modLen > UPPER_BOUND)) {
-          throw Program.Exception.contractExecuteException(
-              new TronException("one or more of base/exponent/modulus length exceeded 1024 bytes"));
+      if (VMConfig.allowTvmOsaka()
+          && (baseLen > UPPER_BOUND || expLen > UPPER_BOUND || modLen > UPPER_BOUND)) {
+        return Pair.of(false, EMPTY_BYTE_ARRAY);
       }
 
       BigInteger base = parseArg(data, ARGS_OFFSET, baseLen);

chainbase/src/main/java/org/tron/core/store/DynamicPropertiesStore.java

@@ -2986,7 +2986,7 @@ public long getAllowTvmOsaka() {
     return Optional.ofNullable(getUnchecked(ALLOW_TVM_OSAKA))
         .map(BytesCapsule::getData)
         .map(ByteArray::toLong)
-        .orElse(0L);
+        .orElse(CommonParameter.getInstance().getAllowTvmOsaka());
   }
 
   public void saveAllowTvmOsaka(long value) {

framework/src/main/java/org/tron/core/config/args/ConfigKey.java

@@ -247,6 +247,7 @@ private ConfigKey() {
   public static final String COMMITTEE_ALLOW_TVM_CANCUN = "committee.allowTvmCancun";
   public static final String COMMITTEE_ALLOW_TVM_BLOB = "committee.allowTvmBlob";
   public static final String COMMITTEE_PROPOSAL_EXPIRE_TIME = "committee.proposalExpireTime";
+  public static final String COMMITTEE_ALLOW_TVM_OSAKA = "committee.allowTvmOsaka";
   public static final String ALLOW_ACCOUNT_ASSET_OPTIMIZATION =
       "committee.allowAccountAssetOptimization";
   public static final String ALLOW_ASSET_OPTIMIZATION = "committee.allowAssetOptimization";

framework/src/test/java/org/tron/common/runtime/vm/AllowTvmOsakaTest.java

@@ -1,13 +1,13 @@
 package org.tron.common.runtime.vm;
 
 import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.lang3.tuple.Pair;
 import org.junit.Assert;
 import org.junit.Test;
 import org.tron.common.utils.ByteUtil;
 import org.tron.core.vm.PrecompiledContracts;
 import org.tron.core.vm.config.ConfigLoader;
 import org.tron.core.vm.config.VMConfig;
-import org.tron.core.vm.program.Program;
 
 @Slf4j
 public class AllowTvmOsakaTest extends VMTestBase {
@@ -17,31 +17,24 @@ public void testEIP7823() {
     ConfigLoader.disable = true;
     VMConfig.initAllowTvmOsaka(1);
 
-    byte[] baseLen = new byte[32];
-    byte[] expLen = new byte[32];
-    byte[] modLen = new byte[32];
+    try {
+      byte[] baseLen = new byte[32];
+      byte[] expLen = new byte[32];
+      byte[] modLen = new byte[32];
 
-    PrecompiledContracts.PrecompiledContract modExp = new PrecompiledContracts.ModExp();
+      PrecompiledContracts.PrecompiledContract modExp = new PrecompiledContracts.ModExp();
 
-    // Valid lens
-    try {
-      modExp.execute(ByteUtil.merge(baseLen, expLen, modLen));
-    } catch (Exception e) {
-      Assert.fail();
-    }
+      // Valid lens: all zeros (0 <= 1024)
+      Pair<Boolean, byte[]> result = modExp.execute(ByteUtil.merge(baseLen, expLen, modLen));
+      Assert.assertTrue(result.getLeft());
 
-    // Invalid lens
-    try {
+      // Invalid lens: baseLen = 0x01000000... = 16777216 > 1024
       baseLen[0] = 0x01;
-      modExp.execute(ByteUtil.merge(baseLen, expLen, modLen));
-    } catch (Exception e) {
-      Assert.assertTrue(e instanceof Program.PrecompiledContractException);
-      return;
+      result = modExp.execute(ByteUtil.merge(baseLen, expLen, modLen));
+      Assert.assertFalse(result.getLeft());
     } finally {
       VMConfig.initAllowTvmOsaka(0);
       ConfigLoader.disable = false;
     }
-
-    Assert.fail();
   }
 }