chore: fixup linter/jest config to handle esm libs

Author: Julusian

meteor/jest.config.js

@@ -3,6 +3,8 @@ const path = require('path')
 const commonConfig = {
 	modulePaths: ['<rootDir>/node_modules/'],
 	moduleNameMapper: {
+		'^@sofie-automation/shared-lib/dist/(.+).js$': '<rootDir>/../packages/shared-lib/src/$1',
+		'^@sofie-automation/shared-lib/dist/(.+)$': '<rootDir>/../packages/shared-lib/src/$1',
 		// Ensure libraries that would match the extension rule are still resolved
 		'bignumber.js': 'bignumber.js',
 		// Drop file extensions in imports

packages/blueprints-integration/jest.config.js

@@ -9,16 +9,18 @@ module.exports = {
 				diagnostics: {
 					ignoreCodes: [
 						151002, // hybrid module kind (Node16/18/Next)
+						2823, // Import attributes not supported in CJS mode (ts-jest forces CJS, emits require() anyway)
 					],
 				},
 			},
 		],
 	},
 	moduleNameMapper: {
+		'^@sofie-automation/shared-lib/dist/(.+)$': '<rootDir>/../shared-lib/src/$1',
 		'(.+)\\.js$': '$1',
 	},
 	testMatch: ['**/__tests__/**/*.spec.(ts|js)'],
-	testPathIgnorePatterns: ['integrationTests'],
+	testPathIgnorePatterns: ['integrationTests', 'dist'],
 	testEnvironment: 'node',
 	coverageThreshold: {
 		global: {

packages/blueprints-integration/tsconfig.build.json

@@ -13,7 +13,8 @@
 		"resolveJsonModule": true,
 		"types": ["node"],
 		"composite": true,
-		"module": "node20"
+		"module": "node20",
+		"esModuleInterop": true
 	},
 	"references": [
 		{

packages/corelib/jest.config.js

@@ -9,12 +9,14 @@ module.exports = {
 				diagnostics: {
 					ignoreCodes: [
 						151002, // hybrid module kind (Node16/18/Next)
+						2823, // Import attributes not supported in CJS mode (ts-jest forces CJS, emits require() anyway)
 					],
 				},
 			},
 		],
 	},
 	moduleNameMapper: {
+		'^@sofie-automation/shared-lib/dist/(.+)$': '<rootDir>/../shared-lib/src/$1',
 		'(.+)\\.js$': '$1',
 	},
 	testMatch: ['**/__tests__/**/*.(spec|test).(ts|js)'],

packages/eslint.config.mjs

@@ -62,7 +62,20 @@ extendedRules.push(
 		files: ['webui/src/**/*', 'shared-lib/src/**/*', 'server-core-integration/src/**/*'],
 		rules: {
 			// Override default behaviour for ESM and verbatimModuleSyntax
-			'n/no-missing-import': ['error', { ignoreTypeImport: true }],
+			'n/no-missing-import': [
+				'error',
+				{
+					ignoreTypeImport: true,
+					resolverConfig: {
+						// The default aliases drop the js version, breaking the /dist imports
+						extensionAlias: {
+							'.js': ['.ts', '.tsx', '.js'],
+							'.cjs': ['.cts', '.cjs'],
+							'.mjs': ['.mts', '.mjs'],
+						},
+					},
+				},
+			],
 			'no-duplicate-imports': 'error',
 			'@typescript-eslint/consistent-type-imports': ['error', { fixStyle: 'inline-type-imports' }],
 			'@typescript-eslint/no-import-type-side-effects': 'error',

packages/job-worker/jest.config.js

@@ -17,13 +17,15 @@ module.exports = {
 						6133, // Declared but not used
 						6192, // All imports are unused
 						151002, // hybrid module kind (Node16/18/Next)
+						2823, // Import attributes not supported in CJS mode (ts-jest forces CJS, emits require() anyway)
 					],
 				},
 			},
 		],
 		'^.+\\.(js|jsx|mjs)$': path.resolve('./scripts/babel-jest.mjs'),
 	},
 	moduleNameMapper: {
+		'^@sofie-automation/shared-lib/dist/(.+)$': '<rootDir>/../shared-lib/src/$1',
 		'(.+)\\.js$': '$1',
 	},
 	transformIgnorePatterns: ['node_modules/(?!(debounce-fn|p-queue|p-timeout)/)', '\\.pnp\\.[^\\/]+$'],

packages/live-status-gateway/jest.config.js

@@ -9,12 +9,17 @@ module.exports = {
 				diagnostics: {
 					ignoreCodes: [
 						151002, // hybrid module kind (Node16/18/Next)
+						2823, // Import attributes not supported in CJS mode (ts-jest forces CJS, emits require() anyway)
 					],
 				},
 			},
 		],
 	},
 	moduleNameMapper: {
+		// Jest is not happy with esm modules, we need to point it to the source files instead
+		'^@sofie-automation/shared-lib/dist/(.+)\\.js$': '<rootDir>/../shared-lib/src/$1',
+		'^@sofie-automation/shared-lib/dist/(.+)$': '<rootDir>/../shared-lib/src/$1',
+		'^@sofie-automation/server-core-integration$': '<rootDir>/../server-core-integration/src/index.ts',
 		'(.+)\\.js$': '$1',
 	},
 	testMatch: ['**/__tests__/**/*.(spec|test).(ts|js)'],

packages/live-status-gateway/src/collections/rundownContentHandlerBase.ts

@@ -6,8 +6,7 @@ import { RundownId } from '@sofie-automation/corelib/dist/dataModel/Ids'
 import { DBRundownPlaylist } from '@sofie-automation/corelib/dist/dataModel/RundownPlaylist/RundownPlaylist'
 import { CollectionHandlers } from '../liveStatusServer.js'
 import { PickKeys } from '@sofie-automation/shared-lib/dist/lib/types'
-import { CollectionDocCheck } from '@sofie-automation/server-core-integration'
-import { ParametersOfFunctionOrNever } from '@sofie-automation/server-core-integration/dist/lib/subscriptions'
+import type { CollectionDocCheck, ParametersOfFunctionOrNever } from '@sofie-automation/server-core-integration'
 
 const PLAYLIST_KEYS = ['currentPartInfo', 'nextPartInfo'] as const
 type Playlist = PickKeys<DBRundownPlaylist, typeof PLAYLIST_KEYS>

packages/live-status-gateway/src/coreHandler.ts

@@ -12,6 +12,7 @@ import {
 	PeripheralDevicePubSubTypes,
 	SubscriptionId,
 	stringifyError,
+	ParametersOfFunctionOrNever,
 } from '@sofie-automation/server-core-integration'
 import { DeviceConfig } from './connector.js'
 import { Logger } from 'winston'
@@ -26,7 +27,6 @@ import { StatusCode } from '@sofie-automation/shared-lib/dist/lib/status'
 import { PeripheralDeviceCommand } from '@sofie-automation/shared-lib/dist/core/model/PeripheralDeviceCommand'
 import { LiveStatusGatewayConfig } from '@sofie-automation/shared-lib/dist/generated/LiveStatusGatewayOptionsTypes'
 import { CorelibPubSubTypes, CorelibPubSubCollections } from '@sofie-automation/corelib/dist/pubsub'
-import { ParametersOfFunctionOrNever } from '@sofie-automation/server-core-integration/dist/lib/subscriptions'
 
 export interface CoreConfig {
 	host: string

packages/live-status-gateway/src/publicationCollection.ts

@@ -5,8 +5,8 @@ import {
 	CollectionDocCheck,
 	PeripheralDevicePubSubCollections,
 	ProtectedString,
+	ParametersOfFunctionOrNever,
 } from '@sofie-automation/server-core-integration'
-import { ParametersOfFunctionOrNever } from '@sofie-automation/server-core-integration/dist/lib/subscriptions'
 import { Logger } from 'winston'
 import { CollectionBase, DEFAULT_THROTTLE_PERIOD_MS } from './collectionBase.js'
 import { CoreHandler } from './coreHandler.js'