chore: remove redundant wrapPartToTemporaryInstance implementations

Author: justandras

packages/job-worker/src/__mocks__/partinstance.ts

@@ -9,7 +9,7 @@ import { protectString, unprotectString } from '@sofie-automation/corelib/dist/p
 import { MockJobContext, setupDefaultJobEnvironment } from '../../__mocks__/context.js'
 import { setupDefaultRundownPlaylist, setupMockShowStyleCompound } from '../../__mocks__/presetCollections.js'
 import { DBRundown } from '@sofie-automation/corelib/dist/dataModel/Rundown'
-import { wrapPartToTemporaryInstance } from '../../__mocks__/partinstance.js'
+import { wrapPartToTemporaryInstance } from '@sofie-automation/corelib/dist/playout/stateCacheResolver'
 import { ReadonlyDeep } from 'type-fest'
 import { convertPartInstanceToBlueprints } from '../context/lib.js'
 import { EmptyPieceTimelineObjectsBlob } from '@sofie-automation/corelib/dist/dataModel/Piece'

packages/job-worker/src/blueprints/__tests__/context-events.test.ts

@@ -7,8 +7,8 @@ import { setupDefaultRundownPlaylist, setupMockShowStyleCompound } from '../../_
 import { getRandomId } from '@sofie-automation/corelib/dist/lib'
 import { DBRundown } from '@sofie-automation/corelib/dist/dataModel/Rundown'
 import { runJobWithPlayoutModel } from '../lock.js'
-import { wrapPartToTemporaryInstance } from '../../__mocks__/partinstance.js'
 import { protectString } from '@sofie-automation/corelib/dist/protectedString'
+import { wrapPartToTemporaryInstance } from '@sofie-automation/corelib/dist/playout/stateCacheResolver'
 
 describe('canContinueAdlibOnEndInfinites', () => {
 	let context: MockJobContext

packages/job-worker/src/playout/__tests__/infinites.test.ts

@@ -9,10 +9,10 @@ import { MockJobContext, setupDefaultJobEnvironment } from '../../../__mocks__/c
 import { runJobWithPlayoutModel } from '../../../playout/lock.js'
 import { defaultRundownPlaylist } from '../../../__mocks__/defaultCollectionObjects.js'
 import _ from 'underscore'
-import { wrapPartToTemporaryInstance } from '../../../__mocks__/partinstance.js'
 import { wrapDefaultObject } from '@sofie-automation/corelib/dist/settings/objectWithOverrides'
 import { QuickLoopMarkerType } from '@sofie-automation/corelib/dist/dataModel/RundownPlaylist'
 import { ForceQuickLoopAutoNext } from '@sofie-automation/shared-lib/dist/core/model/StudioSettings'
+import { wrapPartToTemporaryInstance } from '@sofie-automation/corelib/dist/playout/stateCacheResolver'
 
 describe('getOrderedPartsAfterPlayhead', () => {
 	let context!: MockJobContext

packages/job-worker/src/playout/lookahead/__tests__/util.test.ts

@@ -1,24 +1,8 @@
 import { protectString, unprotectString } from '@sofie-automation/corelib/dist/protectedString'
 import { DBPart } from '@sofie-automation/corelib/dist/dataModel/Part'
 import { PartInstance } from '@sofie-automation/corelib/dist/dataModel/PartInstance'
-import { PartId, RundownPlaylistActivationId } from '@sofie-automation/corelib/dist/dataModel/Ids'
-
-export function wrapPartToTemporaryInstance(
-	playlistActivationId: RundownPlaylistActivationId,
-	part: DBPart
-): PartInstance {
-	return {
-		isTemporary: true,
-		_id: protectString(`${part._id}_tmp_instance`),
-		rundownId: part.rundownId,
-		segmentId: part.segmentId,
-		playlistActivationId,
-		segmentPlayoutId: protectString(''), // Only needed when stored in the db, and filled in nearer the time
-		takeCount: -1,
-		rehearsal: false,
-		part: part,
-	}
-}
+import { PartId } from '@sofie-automation/corelib/dist/dataModel/Ids'
+import { wrapPartToTemporaryInstance } from '@sofie-automation/corelib/dist/playout/stateCacheResolver'
 
 export function findPartInstanceInMapOrWrapToTemporary<T extends Partial<PartInstance>>(
 	partInstancesMap: Map<PartId, T>,

packages/meteor-lib/src/collections/PartInstances.ts

@@ -1,6 +1,5 @@
 import { DBRundownPlaylist, QuickLoopMarkerType } from '@sofie-automation/corelib/dist/dataModel/RundownPlaylist'
 import { ForceQuickLoopAutoNext } from '@sofie-automation/shared-lib/dist/core/model/StudioSettings'
-import { wrapPartToTemporaryInstance } from '@sofie-automation/meteor-lib/dist/collections/PartInstances'
 import { DBPart } from '@sofie-automation/corelib/dist/dataModel/Part'
 import { DBSegment } from '@sofie-automation/corelib/dist/dataModel/Segment'
 import { DBRundown } from '@sofie-automation/corelib/dist/dataModel/Rundown'
@@ -10,6 +9,7 @@ import { RundownTimingCalculator, RundownTimingContext, findPartInstancesInQuick
 import { PlaylistTimingType, SegmentTimingInfo } from '@sofie-automation/blueprints-integration'
 import { PartId, RundownId, SegmentId } from '@sofie-automation/corelib/dist/dataModel/Ids'
 import { PartInstance } from '@sofie-automation/corelib/src/dataModel/PartInstance.js'
+import { wrapPartToTemporaryInstance } from '@sofie-automation/corelib/src/playout/stateCacheResolver'
 
 const DEFAULT_DURATION = 0
 const DEFAULT_NONZERO_DURATION = 4000

packages/webui/src/client/lib/__tests__/rundownTiming.test.ts

@@ -3,7 +3,6 @@ import { Meteor } from 'meteor/meteor'
 import { withTracker } from '../../../lib/ReactMeteorData/react-meteor-data.js'
 import { protectString } from '@sofie-automation/shared-lib/dist/lib/protectedString'
 import { DBRundownPlaylist } from '@sofie-automation/corelib/dist/dataModel/RundownPlaylist'
-import { wrapPartToTemporaryInstance } from '@sofie-automation/meteor-lib/dist/collections/PartInstances'
 import { RundownTiming, TimeEventArgs } from './RundownTiming.js'
 import { Rundown } from '@sofie-automation/corelib/dist/dataModel/Rundown'
 import { DBSegment } from '@sofie-automation/corelib/dist/dataModel/Segment'
@@ -21,7 +20,10 @@ import { RundownPlaylistClientUtil } from '../../../lib/rundownPlaylistUtil.js'
 import { getCurrentTime } from '../../../lib/systemTime.js'
 import { IRundownTimingProviderValues, RundownTimingProviderContext } from './withTiming.js'
 import { PartInstance } from '@sofie-automation/corelib/src/dataModel/PartInstance.js'
-import { deduplicatePartInstancesForQuickLoop } from '@sofie-automation/corelib/src/playout/stateCacheResolver.js'
+import {
+	deduplicatePartInstancesForQuickLoop,
+	wrapPartToTemporaryInstance,
+} from '@sofie-automation/corelib/src/playout/stateCacheResolver.js'
 
 const TIMING_DEFAULT_REFRESH_INTERVAL = 1000 / 60 // the interval for high-resolution events (timeupdateHR)
 const LOW_RESOLUTION_TIMING_DECIMATOR = 15

packages/webui/src/client/ui/RundownView/RundownTiming/RundownTimingProvider.tsx

@@ -32,7 +32,6 @@ import RundownViewEventBus, {
 	RundownViewEvents,
 	HighlightEvent,
 } from '@sofie-automation/meteor-lib/dist/triggers/RundownViewEventBus'
-import { wrapPartToTemporaryInstance } from '@sofie-automation/meteor-lib/dist/collections/PartInstances'
 
 import { SegmentTimelineSmallPartFlag } from './SmallParts/SegmentTimelineSmallPartFlag.js'
 import { UIStateStorage } from '../../lib/UIStateStorage.js'
@@ -57,7 +56,7 @@ import { SelectedElementsContext } from '../RundownView/SelectedElementsContext.
 import { BlueprintAssetIcon } from '../../lib/Components/BlueprintAssetIcon.js'
 import { UIStudio } from '@sofie-automation/corelib/src/dataModel/Studio.js'
 import { PieceUi } from '@sofie-automation/corelib/src/dataModel/Piece.js'
-import { isLoopRunning } from '@sofie-automation/corelib/src/playout/stateCacheResolver.js'
+import { isLoopRunning, wrapPartToTemporaryInstance } from '@sofie-automation/corelib/src/playout/stateCacheResolver.js'
 import { hasUserEditableContent } from '../UserEditOperations/PropertiesPanel.js'
 
 interface IProps {