Implemented CanOverwriteFiles to spare unnecessary calls to GCS#73
Open
mhlavac wants to merge 1 commit into
Open
Implemented CanOverwriteFiles to spare unnecessary calls to GCS#73mhlavac wants to merge 1 commit into
mhlavac wants to merge 1 commit into
Conversation
Filesystem will skip has check if adapter implements CanOverwriteFiles, when dealing with a lot of files this can lead to 50% less requests and up to 50% speed increase.
|
Looks good to me! Would be nice to have this implemented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented CanOverwriteFiles to spare unnecessary calls to GCS
Filesystem will skip has check if adapter implements
CanOverwriteFiles, when dealing with a lot of files this can lead to 50% less requests and up to 50% speed increase.From Filesystem: