don't expand directories on a terminal negation extglob#207
Open
hong4rc wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188. With the default
expandDirectories: true, a pattern ending in a negation extglob returns the files it should exclude —glob(['loc/**/!(en.po)'])hands back everyen.po.The issue is labeled
upstream, but picomatch is correct:picomatch('loc/**/!(en.po)')('loc/one/en.po')isfalse. The bug is in tinyglobby's ownnormalizePattern, which appends/**to any pattern not ending in*— soloc/**/!(en.po)becomesloc/**/!(en.po)/**, and now!(en.po)matches the directory while the trailing/**re-addsen.pounderneath. Running the same glob withexpandDirectories: falsereturns the correct result, confirming the append is the cause.The fix skips the
/**append when the final segment is a negation extglob. It's deliberately narrow — only a terminal!(...)— soloc/**/!(en).poand other forms still expand as before.