Skip to content

Commit a0fb4c1

Browse files
committed
DEBUG: test cp313t (source-built numpy) vs cp314t (prebuilt numpy) on preview MSVC
1 parent 1d645f0 commit a0fb4c1

1 file changed

Lines changed: 11 additions & 9 deletions

File tree

.github/workflows/debug_win_ft.yml

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,12 @@ on:
1515
jobs:
1616
debug_windows_ft:
1717
name: Debug Windows FT (cp313 vs cp313t)
18-
# Use the STABLE MSVC (VS 2022 / MSVC 14.4x) instead of windows-latest
19-
# (which is windows-2025-vs2026 -> preview MSVC 14.51 that miscompiles
20-
# numpy's npy_isnan/npy_isinf in the from-source cp313t build). If cp313t
21-
# now reports all True, the preview compiler is confirmed as the cause.
22-
runs-on: windows-2022
18+
# Back on windows-latest (windows-2025-vs2026 -> PREVIEW MSVC 14.51) ON PURPOSE
19+
# for this run: compare cp313t (no PyPI numpy wheel -> numpy SOURCE-BUILT with
20+
# 14.51 -> expected BROKEN) vs cp314t (PyPI ships a prebuilt numpy wheel ->
21+
# numpy NOT built by 14.51 -> expected FINE). Confirms the bug is the numpy
22+
# source-build compiler, and tells us whether 3.14t is safe on the preview image.
23+
runs-on: windows-latest
2324
strategy:
2425
matrix:
2526
architecture: [x64]
@@ -49,9 +50,9 @@ jobs:
4950
5051
- name: Build wheels and run FT probe (cp313, cp313t)
5152
env:
52-
# Only the two interpreters we need to compare -> much faster than the
53-
# full matrix.
54-
CIBW_BUILD: "cp313-* cp313t-*"
53+
# cp313t: numpy has NO cp313t win wheel -> source-built with preview MSVC.
54+
# cp314t: numpy HAS a prebuilt cp314t win wheel -> not built by preview MSVC.
55+
CIBW_BUILD: "cp313t-* cp314t-*"
5556
CIBW_ENABLE: cpython-prerelease cpython-freethreading
5657
CIBW_ARCHS_WINDOWS: ${{ matrix.architecture == 'x86' && 'x86' || 'AMD64' }}
5758
CIBW_BUILD_VERBOSITY: "3"
@@ -62,7 +63,8 @@ jobs:
6263
# the actual values and always exits 0, so BOTH wheels' output lands in
6364
# the log for a direct [GIL] vs [FT] comparison.
6465
CIBW_TEST_COMMAND_WINDOWS: pip install numpy && pip install --no-deps {wheel} && python {project}/ci_debug/ft_repro.py
65-
CIBW_TEST_EXTRAS: test
66+
# No CIBW_TEST_EXTRAS: the probe only needs numpy + the wheel; installing
67+
# the [test] extra (pandas) can lack a cp314t wheel and stall the run.
6668
shell: pwsh
6769
run: |
6870
python -m cibuildwheel --output-dir wheelhouse

0 commit comments

Comments
 (0)