Skip to content
This repository was archived by the owner on Sep 6, 2018. It is now read-only.

Commit cfc72ed

Browse files
AliSoftwaredjbe
authored andcommitted
Don't forget the full stop!
1 parent f4855f2 commit cfc72ed

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

Dangerfile

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,12 @@ warn("Big PR") if git.lines_of_code > 500
1111
# if git.lines_of_code > 3 && !git.modified_files.include?("CHANGELOG.yml")
1212
if !git.modified_files.include?("CHANGELOG.yml") && !declared_trivial
1313
repo_url = github.pr_json['head']['repo']['html_url']
14+
pr_title = github.pr_title
15+
pr_title += '.' unless pr_title.end_with?('.')
1416
pr_number = github.pr_json['number']
1517
pr_url = github.pr_json['html_url']
16-
pr_title = github.pr_title.sub(/[?.!,;]?$/, '').capitalize
1718
pr_author = github.pr_author
18-
pr_author_url = "https://github.com/#{github.pr_author}"
19+
pr_author_url = "https://github.com/#{pr_author}"
1920

2021
fail("Please include a CHANGELOG entry. \nYou can find it at [CHANGELOG.md](#{repo_url}/blob/master/CHANGELOG.md).")
2122
changelog_msg = <<-CHANGELOG_FORMAT.gsub(/^ *\|/,'')
@@ -26,6 +27,6 @@ if !git.modified_files.include?("CHANGELOG.yml") && !declared_trivial
2627
| [@#{pr_author}](#{pr_author_url})
2728
|```
2829
|:bulb: Don't forget to use 2 spaces after the full stop at the end of the line describing your changes.
29-
CHANGELOG_FORMAT
30+
CHANGELOG_FORMAT
3031
markdown(changelog_msg)
3132
end

0 commit comments

Comments
 (0)