Support optional message metadata tagged with @ (non-RFC)#7
Draft
hermiteer wants to merge 1 commit intoSwiftNIOExtras:developfrom
Draft
Support optional message metadata tagged with @ (non-RFC)#7hermiteer wants to merge 1 commit intoSwiftNIOExtras:developfrom
@ (non-RFC)#7hermiteer wants to merge 1 commit intoSwiftNIOExtras:developfrom
Conversation
Changed IRCMessageParser to look for message metadata
helje5
requested changes
Jun 25, 2024
|
|
||
| if cursor[cursor.startIndex] == cColon { | ||
| // let spaceIdx = cursor.firstIndex(of: cSpace) |
Member
There was a problem hiding this comment.
I think we should probably remove such comments? :-)
| @@ -64,7 +64,8 @@ public protocol IRCDispatcher { | |||
| message : String) throws | |||
| func doMessage (sender : IRCUserID?, | |||
Member
There was a problem hiding this comment.
Would be nice to keep the old API as well for backwards compat, i.e. the one taking no metadata. The default implementation of the one w/ metadata could call into the older method (vs raising notImplemented).
|
|
||
| /* parse metadata */ | ||
|
|
||
| let metadataSource : Swift.Slice<UnsafeRawBufferPointer>? |
Member
There was a problem hiding this comment.
Consistent indent w/ the rest would be nice :-) (I don't personally care too much about indentation styles, but they should be consistent within a project, which is 2-space right now in NIOIRC)
|
|
||
| if cursor[cursor.startIndex] == cAt { | ||
| let startIndex = cursor.startIndex.advanced(by: 1) | ||
| let spaceIdx = line.firstIndex(of: cSpace) |
Member
There was a problem hiding this comment.
Is it safe to assume that the metadata itself doesn't contain spaces? Is there some escaping maybe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added optional metadata string to IRCMessage
Changed IRCMessageParser to look for message metadata