Reduce critical error rate#4048
Draft
finestructure wants to merge 1 commit intomainfrom
Draft
Conversation
daveverwer
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a couple of packages which trigger analysis errors beyond our control. They trigger the following warning whenever they are being analysed:
The reason this warning exists is to make sure we don't end up with most of the analysis queue blocked by packages that can't be analysed.
Raising the limit slightly will allow for single packages failing without triggering a critical warning.
At the same time, we should see if we can let packages with known errors, or rather errors we know that aren't ours, pass analysis, so they don't come around early. What's happening right now is that they are analysed quite frequently, because they're not marked done and put to the end of the queue until next regular analysis.
To do: