rowing back on the "public" modifier

we discussed this internally and do not see any use of adding it, but instead it screws with the modifiers of a lot of classes.

Author: Lutzifer

Tests/ExpectedCode/ExampleA.swift

@@ -4,14 +4,14 @@ import Swinject
 
 extension ResolverType {
 
-    public func resolvePersonType() -> PersonType {
+    func resolvePersonType() -> PersonType {
         return self.resolve(PersonType.self)!
     }
 }
 
 extension Container {
 
-    @discardableResult public func registerPersonType(registerClosure: (_ resolver: ResolverType) -> (PersonType)) -> ServiceEntry<PersonType> {
+    @discardableResult func registerPersonType(registerClosure: (_ resolver: ResolverType) -> (PersonType)) -> ServiceEntry<PersonType> {
         return self.register(PersonType.self, factory: registerClosure)
     }
 }

Tests/ExpectedCode/ExampleB.swift

@@ -4,14 +4,14 @@ import Swinject
 
 extension ResolverType {
 
-    public func resolveInjectablePerson() -> InjectablePerson {
+    func resolveInjectablePerson() -> InjectablePerson {
         return self.resolve(PersonType.self) as! InjectablePerson
     }
 }
 
 extension Container {
 
-    @discardableResult public func registerInjectablePerson(registerClosure: (_ resolver: ResolverType) -> (InjectablePerson)) -> ServiceEntry<PersonType> {
+    @discardableResult func registerInjectablePerson(registerClosure: (_ resolver: ResolverType) -> (InjectablePerson)) -> ServiceEntry<PersonType> {
         return self.register(PersonType.self, factory: registerClosure)
     }
 }

Tests/ExpectedCode/ExampleC.swift

@@ -4,14 +4,14 @@ import Swinject
 
 extension ResolverType {
 
-    public func resolveInjectablePerson_initializer() -> InjectablePerson {
+    func resolveInjectablePerson_initializer() -> InjectablePerson {
         return self.resolve(PersonType.self, name: "initializer") as! InjectablePerson
     }
 }
 
 extension Container {
 
-    @discardableResult public func registerInjectablePerson_initializer(registerClosure: (_ resolver: ResolverType) -> (InjectablePerson)) -> ServiceEntry<PersonType> {
+    @discardableResult func registerInjectablePerson_initializer(registerClosure: (_ resolver: ResolverType) -> (InjectablePerson)) -> ServiceEntry<PersonType> {
         return self.register(PersonType.self, name: "initializer", factory: registerClosure)
     }
 }

Tests/ExpectedCode/ExampleD.swift

@@ -4,14 +4,14 @@ import Swinject
 
 extension ResolverType {
 
-    public func resolveInjectablePerson(argumentName: ArgumentType) -> InjectablePerson {
+    func resolveInjectablePerson(argumentName: ArgumentType) -> InjectablePerson {
         return self.resolve(PersonType.self, argument: argumentName) as! InjectablePerson
     }
 }
 
 extension Container {
 
-    @discardableResult public func registerInjectablePerson(registerClosure: (_ resolver: ResolverType, _ argumentName: ArgumentType) -> (InjectablePerson)) -> ServiceEntry<PersonType> {
+    @discardableResult func registerInjectablePerson(registerClosure: (_ resolver: ResolverType, _ argumentName: ArgumentType) -> (InjectablePerson)) -> ServiceEntry<PersonType> {
         return self.register(PersonType.self, factory: registerClosure)
     }
 }

Tests/ExpectedCode/ExampleE.swift

@@ -4,14 +4,14 @@ import Swinject
 
 extension ResolverType {
 
-    public func resolveInjectablePerson(argumentName: ArgumentType, argumenttypewithoutspecificname: ArgumentTypeWithoutSpecificName, title: String, string: String) -> InjectablePerson {
+    func resolveInjectablePerson(argumentName: ArgumentType, argumenttypewithoutspecificname: ArgumentTypeWithoutSpecificName, title: String, string: String) -> InjectablePerson {
         return self.resolve(PersonType.self, arguments: argumentName, argumenttypewithoutspecificname, title, string) as! InjectablePerson
     }
 }
 
 extension Container {
 
-    @discardableResult public func registerInjectablePerson(registerClosure: (_ resolver: ResolverType, _ argumentName: ArgumentType, _ argumenttypewithoutspecificname: ArgumentTypeWithoutSpecificName, _ title: String, _ string: String) -> (InjectablePerson)) -> ServiceEntry<PersonType> {
+    @discardableResult func registerInjectablePerson(registerClosure: (_ resolver: ResolverType, _ argumentName: ArgumentType, _ argumenttypewithoutspecificname: ArgumentTypeWithoutSpecificName, _ title: String, _ string: String) -> (InjectablePerson)) -> ServiceEntry<PersonType> {
         return self.register(PersonType.self, factory: registerClosure)
     }
 }

Tests/ExpectedCode/ExampleF.swift

@@ -4,14 +4,14 @@ import Swinject
 
 extension ResolverType {
 
-    public func resolveInjectablePerson_initializer(argumentName: ArgumentType, argumenttypewithoutspecificname: ArgumentTypeWithoutSpecificName, title: String, string: String) -> InjectablePerson {
+    func resolveInjectablePerson_initializer(argumentName: ArgumentType, argumenttypewithoutspecificname: ArgumentTypeWithoutSpecificName, title: String, string: String) -> InjectablePerson {
         return self.resolve(PersonType.self, name: "initializer", arguments: argumentName, argumenttypewithoutspecificname, title, string) as! InjectablePerson
     }
 }
 
 extension Container {
 
-    @discardableResult public func registerInjectablePerson_initializer(registerClosure: (_ resolver: ResolverType, _ argumentName: ArgumentType, _ argumenttypewithoutspecificname: ArgumentTypeWithoutSpecificName, _ title: String, _ string: String) -> (InjectablePerson)) -> ServiceEntry<PersonType> {
+    @discardableResult func registerInjectablePerson_initializer(registerClosure: (_ resolver: ResolverType, _ argumentName: ArgumentType, _ argumenttypewithoutspecificname: ArgumentTypeWithoutSpecificName, _ title: String, _ string: String) -> (InjectablePerson)) -> ServiceEntry<PersonType> {
         return self.register(PersonType.self, name: "initializer", factory: registerClosure)
     }
 }

erb/container.erb

@@ -8,15 +8,15 @@ import Swinject
 
 extension ResolverType {
 <% @content_array.each do |hash| %>
-    public func <%= hash[:resolve_function_signature] %> {
+    func <%= hash[:resolve_function_signature] %> {
         return self<%= hash[:resolve_function_call] %><%= ", argument: #{hash[:arguments][0][:argument_name]}" if !hash[:arguments].nil? && hash[:arguments].count == 1 -%><%= ", arguments: #{hash[:arguments].map {|a| a[:argument_name]}.join(", ")}" if !hash[:arguments].nil? && hash[:arguments].count > 1 -%>)<%=hash[:service] != hash[:component] ? " as! #{hash[:component]}" : "!"%>
     }
 <% end -%>
 }
 
 extension Container {
 <% @content_array.each do |hash| %>
-    @discardableResult public func <%= hash[:register_function_signature] %> {
+    @discardableResult func <%= hash[:register_function_signature] %> {
         return self<%= hash[:register_function_call] %> factory: registerClosure)
     }
 <% end -%>