fix: remove case for SessionPort set to 0, fix comment

SalimKayal · leafty · SalimKayal · commit 8658bbb9f580 · 2026-06-17T12:33:56.000+02:00
Co-authored-by: Flora Thiebaut &lt;flora@leafty.dev&gt;
diff --git a/internal/remote/server/server.go b/internal/remote/server/server.go
@@ -131,9 +131,6 @@ func newServer(controller controller.RemoteSessionController, cfg config.RemoteS
 			}
 			return c.NoContent(http.StatusOK)
 		case string(amaltheadevv1alpha1.HTTP):
-			if cfg.SessionPort == 0 {
-				return c.NoContent(http.StatusOK)
-			}
 			client := &http.Client{
 				Timeout: 5 * time.Second,
 				CheckRedirect: func(req *http.Request, via []*http.Request) error {
@@ -159,7 +156,7 @@ func newServer(controller controller.RemoteSessionController, cfg config.RemoteS
 			}
 			return c.NoContent(http.StatusServiceUnavailable)
 		default:
-			// Unconfigured / unknown: preserve old behavior for backward compatibility
+			// Case None or unset: preserve old behavior for backward compatibility
 			return c.NoContent(http.StatusOK)
 		}
 	})

Original file line number	Diff line number	Diff line change
`@@ -131,9 +131,6 @@ func newServer(controller controller.RemoteSessionController, cfg config.RemoteS`
`131`	`131`	`}`
`132`	`132`	`return c.NoContent(http.StatusOK)`
`133`	`133`	`case string(amaltheadevv1alpha1.HTTP):`
`134`		`- if cfg.SessionPort == 0 {`
`135`		`- return c.NoContent(http.StatusOK)`
`136`		`- }`
`137`	`134`	`client := &http.Client{`
`138`	`135`	`Timeout: 5 * time.Second,`
`139`	`136`	`CheckRedirect: func(req http.Request, via []http.Request) error {`
`@@ -159,7 +156,7 @@ func newServer(controller controller.RemoteSessionController, cfg config.RemoteS`
`159`	`156`	`}`
`160`	`157`	`return c.NoContent(http.StatusServiceUnavailable)`
`161`	`158`	`default:`
`162`		`- // Unconfigured / unknown: preserve old behavior for backward compatibility`
	`159`	`+ // Case None or unset: preserve old behavior for backward compatibility`
`163`	`160`	`return c.NoContent(http.StatusOK)`
`164`	`161`	`}`
`165`	`162`	`})`