Skip to content

"feat: add resumeAt to hibernated sessions"#1069

Draft
wesjdj wants to merge 3 commits into
mainfrom
add-resume-hibernated-sessions
Draft

"feat: add resumeAt to hibernated sessions"#1069
wesjdj wants to merge 3 commits into
mainfrom
add-resume-hibernated-sessions

Conversation

@wesjdj

@wesjdj wesjdj commented Jan 26, 2026

Copy link
Copy Markdown
  • chore: starter changes for auto-resume
  • push change to amaltheasession crd
  • feat: add resumeAt to hibernated sessions

@leafty leafty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: handling this purely from Amalthea will create cases where the session will be broken.
Secrets and other important pieces are updated by renku-data-services when a user resumes a session, so a controller-side resume will have broken pieces (authentication, tokens, etc.).

The field can be added to the spec, but adding the handling on the controller is not advised.

@olevski

olevski commented Jan 26, 2026

Copy link
Copy Markdown
Member

Note: handling this purely from Amalthea will create cases where the session will be broken.
Secrets and other important pieces are updated by renku-data-services when a user resumes a session, so a controller-side resume will have broken pieces (authentication, tokens, etc.).

Yes that is a good point. We will have to implement this on the data service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants