fix: Only check pod phase in isPodReady#1127
Merged
Merged
Conversation
This is a quick test. The current impl doesn't work, when there are init containers that are sidecars. They stay in state=running and currently this will always make `isPodReady` return false.
Contributor
|
You can access the deployment of this PR at https://renku-ci-am-1127.dev.renku.ch |
olevski
approved these changes
May 29, 2026
Contributor
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes determining readiness of pod containers. If a sidecar container is added to the
initContainersof a pod, the status check must check aRunningstate and not aTerminatedstate.The
podIsReadyfunction is rewritten to make use of the container status conditions. If a condition exists withType=ReadyandStatus=True, it is considered ready. This removes the investigation of container status./deploy