fix: properly clean up finished jobs and return failure when max-age exceeded#1128
Merged
Conversation
the job is deleted with the amalthea session; it is part of the `needsDeletion` function determining when to remove a session. The job sets its idleSince time when completed.
Contributor
|
You can access the deployment of this PR at https://renku-ci-am-1128.dev.renku.ch |
leafty
reviewed
Jun 4, 2026
leafty
left a comment
leafty
left a comment
Member
There was a problem hiding this comment.
Looks OK, some small comments below.
- better test for SessionTypeNonInteractive to work for old existing resources that don't have that value - short-circuit immediately in updateHibernationState
leafty
approved these changes
Jun 5, 2026
olevski
approved these changes
Jun 8, 2026
Contributor
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ttlSecondsAfterFinishedfor a job. It will only introduce a race conditionmaxHibernatedDurationis passedMaxAgetime, k8s will terminate the pod and the job goes into failed state. This state is now properly propagated to the amalthea session statuscull.gothe jobs are removed from being "hibernated", as this only applies to interactive sessions. Jobs are being removed by k8s automatically due to itsactiveDeadlineSecondssetting/deploy