Skip to content

chore: Use lowercase for local variables in install_rclone #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sambuc merged 1 commit into from
Jun 17, 2026
Merged

chore: Use lowercase for local variables in install_rclone #1137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions internal/remote/firecrest/session_script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ esac
function install_rclone() {
rclone_version=${1:?"install_rclone: Version missing"}
gh_arch=${2:?"install_rclone: Architecture missing"}
RCLONE_PKG="${RENKU_PKG}/rclone/v${rclone_version}"
RCLONE_BIN="${RCLONE_PKG}/rclone"
rclone_pkg="${RENKU_PKG}/rclone/v${rclone_version}"
rclone_bin="${rclone_pkg}/rclone"

skip_install="0"
if [ -f "${RCLONE_BIN}" ]; then
version="$("${RCLONE_BIN}" version || echo "bad executable")"
if [ -f "${rclone_bin}" ]; then
version="$("${rclone_bin}" version || echo "bad executable")"
version="$(echo "${version}" | head -n 1)"
expected="rclone v${rclone_version}"
if [ "${version}" = "${expected}" ]; then
Expand All @@ -53,24 +53,24 @@ function install_rclone() {
fi

if [ "${skip_install}" != "0" ]; then
echo "${RCLONE_BIN}"
echo "${rclone_bin}"
return 0
fi

RCLONE_URL="https://github.com/rclone/rclone/releases/download/v${rclone_version}/rclone-v${rclone_version}-linux-${gh_arch}.zip"
rclone_url="https://github.com/rclone/rclone/releases/download/v${rclone_version}/rclone-v${rclone_version}-linux-${gh_arch}.zip"

mkdir -p "${RCLONE_PKG}"
mkdir -p "${rclone_pkg}"
tmp="$(mktemp -d)"
cwd="$(pwd)"
cd "${tmp}"
curl -Lo "rclone.zip" "${RCLONE_URL}"
curl -Lo "rclone.zip" "${rclone_url}"
>&2 unzip "rclone.zip"
rm -r "${RCLONE_PKG}"
mv ./rclone-v"${rclone_version}"-* "${RCLONE_PKG}"
rm -r "${rclone_pkg}"
mv ./rclone-v"${rclone_version}"-* "${rclone_pkg}"
rm -r "${tmp}"
chmod a+x "${RCLONE_BIN}"
chmod a+x "${rclone_bin}"

echo "${RCLONE_BIN}"
echo "${rclone_bin}"
}

# Installs wstunnel
Expand Down
Loading