Skip to content

chore: Use a loop to go over the folders to create #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sambuc merged 4 commits into from
Jun 17, 2026
Merged

chore: Use a loop to go over the folders to create #1144

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5f5fd8
chore: Improve install_wstunnel robustness
sambuc May 29, 2026
ccd020a
chore: Regroup global variable definitions
sambuc Jun 1, 2026
def8b0d
chore: Use a loop to go over the folders to create
sambuc Jun 1, 2026
151c0b8
Merge branch 'sambuc/fix/cwd-hidden-bug-in-install_rclone' into sambu…
sambuc Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions internal/remote/firecrest/session_script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,11 @@ function install_wstunnel() {
echo "${wstunnel_bin}"
}

echo "SESSION_DIR: ${SESSION_DIR}"
echo "SESSION_WORK_DIR: ${SESSION_WORK_DIR}"

mkdir -p "${SESSION_WORK_DIR}"
mkdir -p "${SECRETS_DIR}"
mkdir -p "${LOGS_DIR}"
for d in SESSION_WORK_DIR SECRETS_DIR LOGS_DIR
do
echo "${d}: ${!d}"
mkdir -p "${!d}"
done

# # Install rclone
# rclone="$(install_rclone "${RCLONE_VERSION}" "${gh_arch}")"
Expand All @@ -135,7 +134,7 @@ mkdir -p "${LOGS_DIR}"
wstunnel="$(install_wstunnel "${WSTUNNEL_VERSION}" "${gh_arch}")"
echo "wstunnel: ${wstunnel}"

# Ensure NVIDIA_VISIBLE_DEVICES is set to void
# Ensure NVIDIA_VISIBLE_DEVICES is set to void
# so that cuda enabled images work on eiger
if !(nvidia-smi 2>&1 >/dev/null); then
export NVIDIA_VISIBLE_DEVICES=void
Expand Down
Loading