chore: Move container-image spec to parameter

internal/remote/firecrest/session_script.sh

@@ -9,11 +9,16 @@
 
 set -e -o pipefail
 
+: ${REMOTE_SESSION_IMAGE:?'not set, aborting!'}
+
 : ${ARCH:=$(uname -m)}
 : ${RENKU_PKG:="${HOME}/.renku/${ARCH}/pkg"}
+: ${GIT_PROXY_PORT:=65480}
+: ${GIT_PROXY_HEALTH_PORT:=65481}
 : ${GIT_PROXY_WAIT_SLEEP_SECONDS:=10}
 : ${GIT_PROXY_WAIT_RETRIES:=10}
 : ${RCLONE_VERSION:="1.70.2"}
+: ${WSTUNNEL_PATH_PREFIX:="sessions/my-session/wstunnel"}
 : ${WSTUNNEL_VERSION:="10.5.5"}
 
 case ${ARCH} in
@@ -29,6 +34,11 @@ case ${ARCH} in
         ;;
 esac
 
+: ${SESSION_DIR:="${PWD}"}
+: ${SESSION_WORK_DIR:="${SESSION_DIR}/work"}
+: ${SECRETS_DIR:="${SESSION_DIR}/secrets"}
+: ${LOGS_DIR:="${SESSION_DIR}/logs"}
+
 # Installs rclone
 #
 # Usage:
@@ -72,7 +82,7 @@ function install_rclone() {
 # Installs wstunnel
 #
 # Usage:
-#     wstunnel="$(install_wstunnel $version $gh_arch)"
+#     wstunnel="$(install_wstunnel "$version" "$gh_arch")"
 #     "$wstunnel" --version
 function install_wstunnel() {
     wstunnel_version=${1:?"wstunnel_version: Version missing"}
@@ -97,32 +107,24 @@ function install_wstunnel() {
 
     mkdir -p "${wstunnel_pkg}"
     tmp="$(mktemp -d)"
-    cwd="$(pwd)"
-    cd "${tmp}"
-    curl -Lo "wstunnel.tar.gz" "${wstunnel_url}"
-    tar xf "wstunnel.tar.gz" -C "${wstunnel_pkg}"
-    cd "${cwd}"
+    (# Run in a sub shell to prevent changing the working directory of the caller
+        cd "${tmp}"
+        curl -Lo "wstunnel.tar.gz" "${wstunnel_url}"
+        rm -rf "${wstunnel_pkg}"
+        mkdir -p ${wstunnel_pkg} # the folder has to exist for tar -C
+        tar xf "wstunnel.tar.gz" -C "${wstunnel_pkg}"
+    )
     rm -r "${tmp}"
     chmod a+x "${wstunnel_bin}"
 
     echo "${wstunnel_bin}"
 }
 
-if [ -z "${REMOTE_SESSION_IMAGE}" ]; then
-    echo "REMOTE_SESSION_IMAGE is not set, aborting!"
-    exit 1
-fi
-
-SESSION_DIR="$(pwd)"
-SESSION_WORK_DIR="${SESSION_DIR}/work"
-SECRETS_DIR="${SESSION_DIR}/secrets"
-LOGS_DIR="${SESSION_DIR}/logs"
-echo "SESSION_DIR: ${SESSION_DIR}"
-echo "SESSION_WORK_DIR: ${SESSION_WORK_DIR}"
-
-mkdir -p "${SESSION_WORK_DIR}"
-mkdir -p "${SECRETS_DIR}"
-mkdir -p "${LOGS_DIR}"
+for d in SESSION_WORK_DIR SECRETS_DIR LOGS_DIR
+do
+    echo "${d}: ${!d}"
+    mkdir -p "${!d}"
+done
 
 # # Install rclone
 # rclone="$(install_rclone "${RCLONE_VERSION}" "${gh_arch}")"
@@ -132,7 +134,7 @@ mkdir -p "${LOGS_DIR}"
 wstunnel="$(install_wstunnel "${WSTUNNEL_VERSION}" "${gh_arch}")"
 echo "wstunnel: ${wstunnel}"
 
-# Ensure NVIDIA_VISIBLE_DEVICES is set to void 
+# Ensure NVIDIA_VISIBLE_DEVICES is set to void
 # so that cuda enabled images work on eiger
 if !(nvidia-smi 2>&1 >/dev/null); then
     export NVIDIA_VISIBLE_DEVICES=void
@@ -141,8 +143,6 @@ fi
 # Create the environment.toml file to run the session
 EDF_FILE="${SESSION_DIR}/environment.toml"
 cat <<EOF >"${EDF_FILE}"
-image = "${REMOTE_SESSION_IMAGE}"
-
 #{{SESSION_MOUNTS_PLACEHOLDER}}
 
 workdir = "${SESSION_WORK_DIR}"
@@ -151,6 +151,8 @@ workdir = "${SESSION_WORK_DIR}"
 com.hooks.cxi.enabled = "false"
 EOF
 
+srun_param_container_image="--container-image ${REMOTE_SESSION_IMAGE}"
+
 export RENKU_MOUNT_DIR="${SESSION_WORK_DIR}"
 export RENKU_WORKING_DIR="${SESSION_WORK_DIR}"
 # Force the frontend to listen on 127.0.0.1
@@ -174,9 +176,6 @@ echo "TODO: setup rclone mounts..."
 # "${rclone}" mount --config "${RCLONE_CONFIG}" --daemon --read-only era5: "${SESSION_WORK_DIR}/era5"
 
 # echo "Starting tunnel..."
-GIT_PROXY_PORT="${GIT_PROXY_PORT:-65480}"
-GIT_PROXY_HEALTH_PORT="${GIT_PROXY_HEALTH_PORT:-65481}"
-WSTUNNEL_PATH_PREFIX="${WSTUNNEL_PATH_PREFIX:-sessions/my-session/wstunnel}"
 echo "wstunnel client \
   -R tcp://0.0.0.0:${RENKU_SESSION_PORT}:localhost:${RENKU_SESSION_PORT} \
   -L tcp://${GIT_PROXY_PORT}:localhost:${GIT_PROXY_PORT} \
@@ -250,6 +249,10 @@ echo "Starting session..."
 # Start session while listening to EXIT signals
 pid=
 trap 'exit_script && [[ $pid ]] && kill -TERM "$pid" && exit_script' EXIT
-srun --environment "${EDF_FILE}" --no-container-entrypoint sh /etc/rc & pid=$!
+srun \
+    --environment "${EDF_FILE}" \
+    ${srun_param_container_image} \
+    --no-container-entrypoint sh /etc/rc \
+    & pid=$!
 wait
 pid=