chore: Reorganise session folder for hpc sessions#1151
Merged
sambuc merged 7 commits intoJun 24, 2026
Merged
Conversation
Introduce two sub folders to separate the session secrets from the data connector configurations as well as the infra secrets.
This was referenced Jun 18, 2026
leafty
reviewed
Jun 22, 2026
| : ${SESSION_DIR:="${PWD}"} | ||
| : ${SESSION_WORK_DIR:="${SESSION_DIR}/work"} | ||
| : ${SECRETS_DIR:="${SESSION_DIR}/secrets"} | ||
| : ${SECRETS_SLOTS_DIR:="${SECRETS_DIR}/slots/"} |
Member
There was a problem hiding this comment.
Let's call them "user secrets":
Suggested change
| : ${SECRETS_SLOTS_DIR:="${SECRETS_DIR}/slots/"} | |
| : ${SECRETS_SLOTS_DIR:="${SECRETS_DIR}/user/"} |
| : ${SESSION_WORK_DIR:="${SESSION_DIR}/work"} | ||
| : ${SECRETS_DIR:="${SESSION_DIR}/secrets"} | ||
| : ${SECRETS_SLOTS_DIR:="${SECRETS_DIR}/slots/"} | ||
| : ${SECRETS_DCS_DIR:="${SECRETS_DIR}/dcs"} |
Member
There was a problem hiding this comment.
Explicit naming:
Suggested change
| : ${SECRETS_DCS_DIR:="${SECRETS_DIR}/dcs"} | |
| : ${SECRETS_DATA_CONNECTORS_DIR:="${SECRETS_DIR}/data_connectors"} |
Base automatically changed from
sambuc/chore/regroup-session-environment-definition
to
feat/secrets-and-dc-in-hpc-sessions
June 22, 2026 11:30
…reorganise-session-folder-for-hpc-sessions
leafty
requested changes
Jun 22, 2026
Comment on lines
+134
to
+137
| for d in \ | ||
| SESSION_DIR \ | ||
| SESSION_WORK_DIR \ | ||
| LOGS_DIR |
Member
There was a problem hiding this comment.
I think you need to have:
SESSION_WORK_DIR(with-pmeans we can skipSESSION_DIR)SECRETS_USER_DIRSECRETS_DATA_CONNECTORS_DIRLOGS_DIR
Contributor
Author
There was a problem hiding this comment.
Thank you for the review, I have added the missing folder variables.
I am explicitly listing all the folder variables in the loop to avoid assumptions about their relationships.
Calling mkdir on a folder which already exists is a no-op, so this should not cause any problems.
olevski
approved these changes
Jun 24, 2026
leafty
approved these changes
Jun 24, 2026
sambuc
merged commit 92d0bb2
into
feat/secrets-and-dc-in-hpc-sessions
6 of 7 checks passed
sambuc
deleted the
sambuc/chore/reorganise-session-folder-for-hpc-sessions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce two sub folders to separate the session secrets from the data
connector configurations as well as the infra secrets.
PR Stack