feat: Upload secrets to HPC cluster#1159
Merged
sambuc merged 2 commits intoJul 10, 2026
Merged
Conversation
This was referenced Jul 8, 2026
leafty
reviewed
Jul 9, 2026
| } | ||
| } | ||
| // Upload user secrets into secretsPath | ||
| secretSlotsPath := path.Join(secretsPath, "slots") |
Member
There was a problem hiding this comment.
These are not called slots. The slot is the "shape" of the secret, it tells the user what type of secret they need to provide and which filename it will populate.
Suggested change
| secretSlotsPath := path.Join(secretsPath, "slots") | |
| secretSlotsPath := path.Join(secretsPath, "user") |
Contributor
Author
There was a problem hiding this comment.
Sorry, this went past me, we had discussed this already. I'll make sure this is fixed everywhere it needs to be.
leafty
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack